romfast/atm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
0f430dae21c8a704a95fef7955ed015dd21f694a
atm/docs/happy-swinging-mccarthy.md
Claude Agent 9207197a56 initial: scaffold atm trading monitor (Faza 1) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-15 22:03:36 +00:00

2.1 KiB
Raw Blame History

Plan: ATM Eng Review — Findings Applied

Context

User ran /plan-eng-review on partitioned-honking-unicorn.md (ATM trading monitor, Faza 1). Eng review complete. All 4 decisions resolved, obvious fixes applied, plan file updated in place.

Where the changes live

The reviewed plan (with all eng-review edits) is at: /home/claude/.claude/plans/partitioned-honking-unicorn.md

Test plan artifact at: ~/.gstack/projects/romfast-workspace/claude-master-eng-review-test-plan-20260415-212932.md

What changed in the reviewed plan

4 decisions (AskUserQuestion)

  1. Bar flicker → debounce depth=1 (configurable); screenshot in alert = visual check.
  2. Phase A entry price → dropped; Phase A is direction + screenshot only; user puts manual 0.6% SL in TradeLocker; Phase B sends real levels from chart.
  3. Notifier blocking → fire-and-forget worker threads per backend, bounded queue, retry + dead-letter.
  4. Alert SPoF → Discord + Telegram parallel from day 1.

Obvious fixes (stated, applied)

  • Exhaustive state transition table (default-noise rule, SELL mirror explicit, phase-skip handling).
  • Python 3.11+ pin → drop tomli, use stdlib tomllib.
  • Windows symlink replaced by configs/current.txt marker file.
  • New vision.py shared module (ROI/hash/interp/Hough).
  • @dataclass Config with load-time validation.
  • DPI check added to calibrate + README note.

Test coverage

Expanded from state-machine-only to: every module + 1 E2E replay harness. Acceptance gate unchanged (precision=100%, recall≥95% on labeled corpus).

Verification (post-implementation)

Run the full verification checklist from partitioned-honking-unicorn.md (sections 1-9). Specifically:

  • pytest tests/ — all new unit tests + E2E replay pass.
  • atm dryrun ./samples hits acceptance gate.
  • Live 2-session test: both Discord and Telegram fire; kill one mid-session and confirm the other still delivers + dead-letter file gets the failed alert.

Status

CEO + ENG CLEARED. No further reviews required before implementation. Design + DX reviews properly skipped (no UI scope; personal single-user tool). Run /ship after implementation.