feat: add clients nomenclator, order edit/delete/devalidate, invoice types, dashboard redesign

- New clients table with PF/PJ support, fiscal data (CUI, IBAN, eFactura fields) - Full CRUD API for clients with search, sync integration - Order lifecycle: edit header (DRAFT), devalidate (VALIDAT→DRAFT), delete order/invoice - Invoice types: FACTURA (B2B) vs BON_FISCAL (B2C) with different nr formats - OrderCreateView redesigned as multi-step flow (client→vehicle→details) - Autocomplete from catalog_norme/catalog_preturi in OrderLineForm - Dashboard now combines stats + full orders table with filter tabs and search - ClientPicker and VehiclePicker with inline creation capability - Frontend schema aligned with backend (missing columns causing sync errors) - Mobile responsive fixes for OrderDetailView buttons Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-14 00:36:40 +02:00
parent 3e449d0b0b
commit 9db4e746e3
34 changed files with 2221 additions and 211 deletions
--- a/docs/PLAN.md
+++ b/docs/PLAN.md
@@ -245,13 +245,18 @@ catalog_tipuri_deviz (id, tenant_id, denumire)
 catalog_tipuri_motoare (id, tenant_id, denumire)
 mecanici (id, tenant_id, user_id, nume, prenume, activ)

+-- Clients (nomenclator clienti cu date eFactura ANAF)
+clients (id, tenant_id, tip_persoana, denumire, cod_fiscal, reg_com,
+         adresa, judet, oras, cod_postal, tara, telefon, email,
+         cont_iban, banca, observatii, activ, created_at, updated_at)
+
 -- Core Business
-vehicles (id, tenant_id, client_nume, client_telefon, client_email,
+vehicles (id, tenant_id, client_id, client_nume, client_telefon, client_email,
          client_cod_fiscal, client_adresa, nr_inmatriculare,
          marca_id, model_id, an_fabricatie, serie_sasiu,
          tip_motor_id, created_at, updated_at)

-orders (id, tenant_id, nr_comanda, data_comanda, vehicle_id,
+orders (id, tenant_id, nr_comanda, data_comanda, vehicle_id, client_id,
        tip_deviz_id, status, km_intrare, observatii,
        -- client snapshot (denormalized)
        client_nume, client_telefon, nr_auto, marca_denumire, model_denumire,
@@ -266,8 +271,8 @@ order_lines (id, order_id, tenant_id, tip, descriere,
             um, cantitate, pret_unitar,     -- material
             total, mecanic_id, ordine, created_at, updated_at)

-invoices (id, tenant_id, order_id, nr_factura, serie_factura,
-          data_factura, modalitate_plata,
+invoices (id, tenant_id, order_id, client_id, nr_factura, serie_factura,
+          data_factura, tip_document, modalitate_plata,
          client_nume, client_cod_fiscal, nr_auto,
          total_fara_tva, tva, total_general, created_at, updated_at)

@@ -379,6 +384,46 @@ _sync_state (table_name, last_sync_at)
 4. Responsive testing (phone, tablet, desktop)
 5. Reports: sumar lunar, export CSV

+### Faza 8: Nomenclator Clienti (Clients)
+**Livrabil: CRUD clienti cu date eFactura ANAF, legatura 1:N cu vehicule**
+
+1. Model `clients` + migrare Alembic (backend)
+2. `client_id` FK pe `vehicles`, `orders`, `invoices`
+3. CRUD endpoints: `GET/POST /api/clients`, `GET/PUT/DELETE /api/clients/{id}`
+4. wa-sqlite schema update (tabel `clients`, FK-uri)
+5. Frontend: pagina Clienti (list, create, edit, delete)
+6. Frontend: selector client in VehiclePicker si OrderCreate
+7. Sync: adauga `clients` in `SYNCABLE_TABLES`
+8. Playwright E2E tests (desktop + mobile)
+
+### Faza 9: Edit/Delete/Devalidare Comenzi
+**Livrabil: Gestionare completa comenzi - edit, stergere, devalidare**
+
+1. `PUT /api/orders/{id}` - edit header comanda (doar in DRAFT)
+2. `DELETE /api/orders/{id}` - stergere comanda (orice nefacturat)
+3. `POST /api/orders/{id}/devalidate` - VALIDAT → DRAFT
+4. `DELETE /api/invoices/{id}` - stergere factura (permite stergere comanda FACTURAT)
+5. Frontend: butoane edit/delete/devalidare pe OrderDetail
+6. Confirmare stergere cu modal
+7. Playwright E2E tests
+
+### Faza 10: Integrare Nomenclator Clienti
+**Livrabil: Clienti integrati in flux comenzi si facturi**
+
+1. Auto-populare date client pe comanda din nomenclator
+2. Selectie client existent sau creare client nou la vehicul
+3. Validare date client complete la facturare (CUI, adresa)
+4. PDF factura cu date client din nomenclator
+
+### Faza 11: Bon Fiscal (tip_document)
+**Livrabil: Suport dual FACTURA + BON_FISCAL pe invoices**
+
+1. `tip_document` pe invoices: FACTURA (B2B, eFactura) sau BON_FISCAL (B2C, casa de marcat)
+2. Factura: necesita date client complete (CUI, adresa)
+3. Bon fiscal: format simplificat, fara date client obligatorii
+4. UI: selectie tip document la facturare
+5. PDF template diferentiat pentru bon fiscal
+
 ---

 ## Referinta din Prototip (doar consultare)
@@ -405,6 +450,9 @@ SaaS-ul trebuie sa fie compatibil cu ROAAUTO VFP9+Oracle. Clientii care cresc po
 | `order_lines` (tip=manopera) | `dev_oper` | SaaS unifica oper+materiale in order_lines |
 | `order_lines` (tip=material) | `dev_estimari_produse` | Acelasi tabel, filtrat pe `tip` |
 | `vehicles` | `dev_masiniclienti` | Renamed, aceleasi coloane client+vehicul |
+| `clients` | `nom_parteneri` + `adrese_parteneri` | Adrese simplificate flat |
+| `clients.tip_persoana` | `nom_parteneri.tip_persoana` | PF/PJ |
+| `clients.cod_fiscal` | `nom_parteneri.cod_fiscal` | CUI sau CNP |
 | `catalog_marci` | `dev_nom_marci` | +tenant_id |
 | `catalog_modele` | `dev_nom_masini` | Identic |
 | `catalog_ansamble` | `dev_nom_ansamble` | +tenant_id |
@@ -414,6 +462,10 @@ SaaS-ul trebuie sa fie compatibil cu ROAAUTO VFP9+Oracle. Clientii care cresc po
 | `catalog_tipuri_motoare` | `dev_tipuri_motoare` | +tenant_id |
 | `mecanici` | `dev_mecanici` | +tenant_id, +user_id |
 | `invoices` | `facturi` (local) | Identic structural |
+| `invoices.tip_document` | `vanzari.tip_factura` | FACTURA/BON_FISCAL |
+| `invoices.client_id` | `vanzari.id_part` | FK la client |
+| `orders.client_id` | (denormalizat) | Referinta directa la client |
+| `vehicles.client_id` | (implicit in dev_masiniclienti) | 1:N client → vehicule |
 | `tenants` | - | Doar SaaS (nu exista in Oracle) |
 | `users` | - | Doar SaaS |
 | `appointments` | - | Doar SaaS (feature nou) |
--- a/docs/api-contract.json
+++ b/docs/api-contract.json
@@ -21,7 +21,7 @@
      "headers": {"Authorization": "Bearer <token>"},
      "response": {
        "tables": {
-          "vehicles": [], "orders": [], "order_lines": [],
+          "clients": [], "vehicles": [], "orders": [], "order_lines": [],
          "invoices": [], "appointments": [],
          "catalog_marci": [], "catalog_modele": [],
          "catalog_ansamble": [], "catalog_norme": [],
@@ -42,12 +42,22 @@
  },
  "orders": {
    "GET /orders": {"response": [{"id": "str", "status": "str", "nr_auto": "str", "total_general": 0}]},
-    "POST /orders": {"body": {"vehicle_id": "str", "tip_deviz_id": "str", "km_intrare": 0, "observatii": "str"}, "response": {"id": "str"}},
+    "POST /orders": {"body": {"vehicle_id": "str", "client_id": "str", "tip_deviz_id": "str", "km_intrare": 0, "observatii": "str"}, "response": {"id": "str"}},
    "GET /orders/{id}": {"response": {"id": "str", "status": "str", "lines": []}},
+    "PUT /orders/{id}": {"body": {"vehicle_id": "str", "client_id": "str", "tip_deviz_id": "str", "km_intrare": 0, "observatii": "str"}, "note": "Edit header - doar in DRAFT"},
+    "DELETE /orders/{id}": {"response": {"ok": true}, "note": "Stergere - orice nefacturat; FACTURAT = sterge factura intai"},
    "POST /orders/{id}/lines": {"body": {"tip": "manopera|material", "descriere": "str", "ore": 0, "pret_ora": 0, "cantitate": 0, "pret_unitar": 0, "um": "str"}},
    "POST /orders/{id}/validate": {"response": {"status": "VALIDAT"}},
+    "POST /orders/{id}/devalidate": {"response": {"status": "DRAFT"}, "note": "VALIDAT → DRAFT"},
    "GET /orders/{id}/pdf/deviz": {"response": "application/pdf"}
  },
+  "clients": {
+    "GET /clients": {"response": [{"id": "str", "tip_persoana": "PF|PJ", "denumire": "str", "cod_fiscal": "str", "telefon": "str", "email": "str", "activ": true}]},
+    "POST /clients": {"body": {"tip_persoana": "PF|PJ", "denumire": "str", "cod_fiscal": "str", "reg_com": "str", "adresa": "str", "judet": "str", "oras": "str", "cod_postal": "str", "tara": "str", "telefon": "str", "email": "str", "cont_iban": "str", "banca": "str", "observatii": "str"}, "response": {"id": "str"}},
+    "GET /clients/{id}": {"response": {"id": "str", "tip_persoana": "str", "denumire": "str", "cod_fiscal": "str", "vehicles": []}},
+    "PUT /clients/{id}": {"body": {"denumire": "str", "cod_fiscal": "str", "adresa": "str"}, "response": {"id": "str"}},
+    "DELETE /clients/{id}": {"response": {"ok": true}}
+  },
  "vehicles": {
    "GET /vehicles": {"response": [{"id": "str", "nr_auto": "str", "marca": "str", "model": "str", "an": 0}]},
    "POST /vehicles": {"body": {"nr_auto": "str", "marca_id": "str", "model_id": "str", "an_fabricatie": 0, "vin": "str", "proprietar_nume": "str", "proprietar_telefon": "str"}},
@@ -60,8 +70,9 @@
    "POST /p/{token}/reject": {"response": {"ok": true}}
  },
  "invoices": {
-    "POST /invoices": {"body": {"order_id": "str"}, "response": {"id": "str", "nr_factura": "str"}},
-    "GET /invoices/{id}/pdf": {"response": "application/pdf"}
+    "POST /invoices": {"body": {"order_id": "str", "client_id": "str", "tip_document": "FACTURA|BON_FISCAL"}, "response": {"id": "str", "nr_factura": "str"}},
+    "GET /invoices/{id}/pdf": {"response": "application/pdf"},
+    "DELETE /invoices/{id}": {"response": {"ok": true}, "note": "Sterge factura, comanda revine la VALIDAT"}
  },
  "users": {
    "GET /users": {"response": [{"id": "str", "email": "str", "rol": "str"}]},
--- a/docs/playwright-report-2026-03-14.md
+++ b/docs/playwright-report-2026-03-14.md
@@ -0,0 +1,68 @@
+# Playwright Test Report - 2026-03-14
+
+## Summary
+- Total: 31
+- Pass: 27
+- Fail: 2
+- Skipped: 2
+
+## Notes
+- The app uses in-memory SQLite (wa-sqlite `:memory:`). On full page reload, all local data is lost and must be re-synced.
+- Sync had errors due to schema mismatches (`table vehicles has no column named vi...`, `table catalog_marci has no column named...`), which prevented demo data from loading. All tests were performed with locally-created data.
+- The `tip_deviz` dropdown was empty because `tipuri_deviz` table had no data (sync failed).
+
+## Desktop Tests (1280x720)
+
+| Test | Description | Status | Notes |
+|------|-------------|--------|-------|
+| T1 | Login + Dashboard | PASS | Login with demo@roaauto.ro works. Dashboard shows stats cards (Total, Draft, Validate, Facturate) and orders table with filter tabs. |
+| T2 | Comanda noua button | PASS | Clicking "+ Comanda noua" navigates to /orders/new with step-by-step wizard. |
+| T3 | Full order creation | PASS | Created order with inline client+vehicle. Redirected to order detail with correct data (B 999 TST, Test SRL E2E, Dacia Logan, KM 55000). |
+| T4 | Inline client creation (PJ) | PASS | "+ Client nou" opens inline form. Switching to PJ shows denumire/CUI/telefon fields. Client created and auto-selected with "(RO12345678)" display. |
+| T5 | Inline vehicle creation | PASS | "+ Vehicul nou" opens form. "+" buttons for marca/model allow inline creation (Dacia/Logan). Vehicle created and auto-selected as "B 999 TST - (Dacia Logan)". |
+| T6 | Clients page | PASS | Added PF client (Popescu Ion). Search by name filters correctly. Click row opens edit form with pre-filled data. Updated email saved successfully. |
+| T7 | Edit order header | PASS | "Editeaza" opens edit form with pre-filled fields. Changed KM from 55000 to 60000 and observatii. Changes persisted after save. |
+| T8 | Add manopera from nomenclator | PASS | Manopera line "Schimb ulei motor" added with 2h * 100 RON/h = 200.00 RON. Line appears in table with MAN badge. Autocomplete from catalog_norme not testable (no synced data). |
+| T9 | Add material from catalog | PASS | Material line "Filtru ulei" added with 1 buc * 50 RON = 50.00 RON. MAT badge shown. Totals updated: Manopera 200, Materiale 50, Total general 250. |
+| T10 | Validate then devalidate | PASS | "Valideaza" changes status to VALIDAT, shows PDF Deviz/Devalideaza/Factureaza buttons, hides line delete buttons. "Devalideaza" with confirmation reverts to DRAFT. |
+| T11 | Delete DRAFT order | PASS | "Sterge" shows confirmation dialog. "Da, sterge" deletes order and redirects to /dashboard. |
+| T12 | Dashboard filters | PASS | Draft tab shows "Nicio comanda gasita" (0 draft). Facturate tab shows FACTURAT orders. Toate shows all. Validate tab works. |
+| T13 | Dashboard search | PASS | Searching "B 999" finds matching order. Searching "XXXXXX" shows "Nicio comanda gasita". |
+| T14 | /orders redirect | PASS | Navigating to /orders redirects to /dashboard. |
+| T15 | Catalog Norme | PASS | Added ansamblu "Motor" first. Then added norma NRM-001 "Schimb ulei si filtre" with ansamblu Motor and 1.5 ore normate. Appears in table. |
+| T16 | Facturare dialog | PASS | "Factureaza" on VALIDAT order shows "Tip document" dialog with Factura (default) and Bon fiscal radio options. |
+| T17 | Factura creation | PASS | Choosing Factura and clicking "Creeaza" changes status to FACTURAT. "Sterge factura" button appears. |
+| T18 | Bon fiscal creation | PASS | After deleting invoice, re-factureaza with "Bon fiscal" selected. Status becomes FACTURAT. Invoice number starts with "ROABF-" confirming Bon Fiscal type. |
+| T19 | InvoicesView | PASS | /invoices shows table with Nr. factura, Tip (BON FISCAL badge), Data, Client, Nr. auto, Total, PDF download button. |
+| T20 | Delete invoice | PASS | "Sterge factura" shows confirmation. "Da, sterge" reverts order to VALIDAT with Devalideaza/Factureaza buttons restored. |
+
+## Mobile Tests (375x812)
+
+| Test | Description | Status | Notes |
+|------|-------------|--------|-------|
+| T21 | Dashboard responsive | PASS | Stats cards stack in 2x2 grid. Filter buttons and search visible. "+ Comanda noua" button accessible. Bottom nav visible. |
+| T22 | Order form responsive | PASS | Form fields stack vertically. Client picker full-width. "+ Client nou" button accessible. "Inapoi" link visible. |
+| T23 | OrderDetail responsive | FAIL | Action buttons (Editeaza, Valideaza, Sterge, DRAFT badge) crowd/overlap with order number heading on narrow screens. The CMD number wraps to 2 lines while buttons stack alongside. Totals area partially obscured by bottom nav. |
+| T24 | Clients responsive | PASS | Heading and "+ Adauga client" button fit. Search field full-width. "Clienti" highlighted in bottom nav. Table replaced with empty state message on fresh load. |
+| T25 | Bottom nav | PASS | Bottom navigation shows on mobile with: Acasa, Clienti, Vehicule, Programari, Setari. Active link is highlighted. |
+
+## Visual Checks
+
+| Test | Description | Status | Notes |
+|------|-------------|--------|-------|
+| T26 | Overflow check | PASS | No horizontal overflow detected on any page. Content stays within viewport bounds on mobile. |
+| T27 | Button spacing | FAIL | On mobile OrderDetail, the action buttons (Editeaza/Valideaza/Sterge) and DRAFT badge are cramped with the heading. They flow into the same line space as the 2-line CMD number, creating a crowded layout. Recommend stacking buttons below heading on mobile. |
+| T28 | Text truncation | PASS | No problematic text truncation observed. Client names, plate numbers, and amounts display fully. |
+| T29 | Modal/dialog display | PASS | Factureaza "Tip document" modal displays centered on desktop with backdrop. Delete confirmation dialogs render properly on both desktop and mobile. |
+| T30 | Badge colors | PASS | MAN (blue), MAT (purple/pink), DRAFT (yellow outline), VALIDAT (green), FACTURAT (green), PF (gray), PJ (blue), BON FISCAL (dark) - all badges render with distinct colors. |
+| T31 | Dialog on mobile | PASS | Delete confirmation dialog renders inline on mobile, fully readable with accessible buttons. No overflow or clipping. |
+
+## Sync Issues Observed
+- `SQLiteError: table vehicles has no column named vi...` - repeated on fullSync
+- `SQLiteError: table catalog_marci has no column named...` - on fullSync
+- These errors prevented demo seed data from syncing to the frontend. The schema in `frontend/src/db/schema.js` may be out of sync with the backend model changes.
+
+## Recommendations
+1. **Fix mobile OrderDetail layout (T23/T27)**: Stack action buttons below the heading on screens < 640px. Consider using `flex-wrap` or a separate row for buttons.
+2. **Fix sync schema mismatch**: The `vehicles` and `catalog_marci` tables in `frontend/src/db/schema.js` are missing columns that the backend sync sends. This breaks fullSync for all users.
+3. **Bottom nav overlap**: On order detail mobile, the totals section at the bottom is partially hidden behind the bottom navigation bar. Add `padding-bottom` to account for the fixed bottom nav height.