Files
rar-autopass/tests/test_worker_active_gate.py
Claude Agent 504b490d3b feat(web): self-onboarding multi-tenant + auth sesiune (PRD 3.3a)
Canalul web trece de la 100% deschis (hardcodat cont 1) la autentificat si
multi-tenant. Un service nou se inregistreaza din browser, primeste o cheie API
(o singura data) si o sesiune; contul se creeaza "in asteptare" (active=0) si nu
trimite la RAR pana la activarea de catre admin (tools/account.py activate).

- users + app/users.py: parole scrypt (salt per-user, eticheta parametri onorata
  la verify pentru migrare cost), email unic case-insensitive
- sesiune: SessionMiddleware (same_site=strict, https_only config) + app/web/session.py
  (current_account/web_account/require_login->LoginRequired, set_session clear-inainte)
- CSRF (app/web/csrf.py) enforce in prod inclusiv pe login/signup + rate-limit
  in-proces (app/web/ratelimit.py) pe signup si login
- signup/login/logout (app/web/auth_routes.py): signup tranzactie atomica,
  cheie-o-data, log SIGNUP pentru descoperire admin
- dashboard + import scoped pe contul sesiunii (regula NULL->cont 1); toate rutele
  web care ating date sensibile sub require_login; nomenclator ramane global
- banner "cont in asteptare" pentru conturi active=0
- gate worker: claim_one LEFT JOIN accounts COALESCE(active,1)=1 (account_id NULL=activ)

VERIFY context curat (2 runde): leak cross-account /_fragments/mapari prins+reparat.
/code-review high: csrf_token lipsa pe re-randari de eroare, scrypt_params ignorat,
login fara rate-limit -- toate reparate. 361 teste pass (de la 313).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-18 16:43:21 +00:00

146 lines
4.9 KiB
Python

"""Teste US-008 — gate worker: claim_one sare submission-urile conturilor inactive.
TDD: testele se scriu INAINTE de modificarea claim_one; la inceput pica (RED),
dupa modificare trec (GREEN).
C14: LEFT JOIN accounts + COALESCE(a.active, 1) = 1
(a) cont legacy fara active -> COALESCE(NULL,1)=1 -> tratat ca activ
(b) submissions.account_id IS NULL (ON DELETE SET NULL) -> LEFT JOIN lasa
a.active NULL -> COALESCE(NULL,1)=1 -> tratat ca activ/default
"""
from __future__ import annotations
import json
import os
import tempfile
import pytest
# --- Fixture DB (pattern din test_worker_reconcile.py) ---
@pytest.fixture()
def env(monkeypatch):
tmp = tempfile.mkdtemp()
monkeypatch.setenv("AUTOPASS_DB_PATH", os.path.join(tmp, "t.db"))
from app.config import get_settings
get_settings.cache_clear()
from app.db import get_connection, init_db
init_db()
conn = get_connection()
yield conn, get_settings()
conn.close()
get_settings.cache_clear()
# --- Helpers ---
_CONTENT = {
"vin": "WVWZZZ1KZAW000123", "nr_inmatriculare": "B999TST",
"data_prestatie": "2026-06-15", "odometru_final": "123456",
"prestatii": [{"cod_prestatie": "OE-1"}], "sistem_reparat": "null",
}
def _insert(conn, account_id=None, status="queued", content=None):
content = content or _CONTENT
cur = conn.execute(
"INSERT INTO submissions (idempotency_key, status, payload_json, account_id) "
"VALUES (?, ?, ?, ?)",
(f"key-{os.urandom(4).hex()}", status, json.dumps(content), account_id),
)
return int(cur.lastrowid)
def _row_status(conn, sid):
return conn.execute("SELECT status FROM submissions WHERE id=?", (sid,)).fetchone()["status"]
# --- Teste ---
def test_claim_sare_cont_inactiv(env):
"""Cont inactiv (active=0) -> claim_one nu ridica submission-ul; ramane queued."""
from app.accounts import create_account
from app.worker.__main__ import claim_one
conn, _ = env
acct_id = create_account(conn, "Service Inactiv", active=False)
sid = _insert(conn, account_id=acct_id)
result = claim_one(conn)
assert result is None, "claim_one trebuia sa returneze None pentru cont inactiv"
assert _row_status(conn, sid) == "queued", "submission-ul trebuia sa ramana queued"
def test_claim_ia_cont_activ(env):
"""Cont activ (active=1) -> claim_one ridica submission-ul si il marcheaza sending."""
from app.accounts import create_account
from app.worker.__main__ import claim_one
conn, _ = env
acct_id = create_account(conn, "Service Activ", active=True)
sid = _insert(conn, account_id=acct_id)
result = claim_one(conn)
assert result is not None, "claim_one trebuia sa returneze submission-ul pentru cont activ"
assert result["id"] == sid
assert _row_status(conn, sid) == "sending"
def test_activare_deblocheaza_trimiterea(env):
"""Cont initial inactiv -> claim_one None; dupa set_active(True) -> claim_one ridica randul."""
from app.accounts import create_account, set_active
from app.worker.__main__ import claim_one
conn, _ = env
acct_id = create_account(conn, "Service Provizoriu", active=False)
sid = _insert(conn, account_id=acct_id)
assert claim_one(conn) is None, "inainte de activare claim_one trebuia sa returneze None"
assert _row_status(conn, sid) == "queued"
set_active(conn, acct_id, True)
result = claim_one(conn)
assert result is not None, "dupa activare claim_one trebuia sa returneze submission-ul"
assert result["id"] == sid
assert _row_status(conn, sid) == "sending"
def test_claim_account_null_tratat_activ(env):
"""submission.account_id IS NULL (ON DELETE SET NULL) -> LEFT JOIN lasa a.active NULL
-> COALESCE(NULL,1)=1 -> tratat ca activ; claim_one il ridica."""
from app.worker.__main__ import claim_one
conn, _ = env
sid = _insert(conn, account_id=None)
result = claim_one(conn)
assert result is not None, "submission cu account_id NULL trebuia sa fie ridicat (tratat ca activ)"
assert result["id"] == sid
assert _row_status(conn, sid) == "sending"
def test_claim_cont_legacy_fara_active(env):
"""Simuleaza cont legacy: LEFT JOIN nu gaseste randul in accounts (account_id nul dupa stergere cont)
-> a.active=NULL dupa JOIN -> COALESCE(NULL,1)=1 -> tratat ca activ.
Nota: schema curenta are active NOT NULL, deci NULL pe coloana `active` e imposibil;
COALESCE acopera NULL-ul de pe a.active produs de LEFT JOIN fara match, nu din coloana.
Simulam prin setarea directa a account_id la NULL (ca dupa ON DELETE SET NULL).
"""
from app.worker.__main__ import claim_one
conn, _ = env
sid = _insert(conn, account_id=None)
conn.execute("UPDATE submissions SET account_id=NULL WHERE id=?", (sid,))
result = claim_one(conn)
assert result is not None, "submission fara cont (account_id NULL) trebuia tratat ca activ"
assert result["id"] == sid