Canalul web trece de la 100% deschis (hardcodat cont 1) la autentificat si multi-tenant. Un service nou se inregistreaza din browser, primeste o cheie API (o singura data) si o sesiune; contul se creeaza "in asteptare" (active=0) si nu trimite la RAR pana la activarea de catre admin (tools/account.py activate). - users + app/users.py: parole scrypt (salt per-user, eticheta parametri onorata la verify pentru migrare cost), email unic case-insensitive - sesiune: SessionMiddleware (same_site=strict, https_only config) + app/web/session.py (current_account/web_account/require_login->LoginRequired, set_session clear-inainte) - CSRF (app/web/csrf.py) enforce in prod inclusiv pe login/signup + rate-limit in-proces (app/web/ratelimit.py) pe signup si login - signup/login/logout (app/web/auth_routes.py): signup tranzactie atomica, cheie-o-data, log SIGNUP pentru descoperire admin - dashboard + import scoped pe contul sesiunii (regula NULL->cont 1); toate rutele web care ating date sensibile sub require_login; nomenclator ramane global - banner "cont in asteptare" pentru conturi active=0 - gate worker: claim_one LEFT JOIN accounts COALESCE(active,1)=1 (account_id NULL=activ) VERIFY context curat (2 runde): leak cross-account /_fragments/mapari prins+reparat. /code-review high: csrf_token lipsa pe re-randari de eroare, scrypt_params ignorat, login fara rate-limit -- toate reparate. 361 teste pass (de la 313). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
126 lines
4.6 KiB
Python
126 lines
4.6 KiB
Python
"""Teste US-005 (PRD 3.3): scoping dashboard pe sesiune (2 conturi, citiri).
|
|
|
|
Comportamental (C6): nu grep, ci verificare reala cu 2 conturi + date distincte.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import tempfile
|
|
|
|
import pytest
|
|
from fastapi.testclient import TestClient
|
|
|
|
|
|
@pytest.fixture()
|
|
def env(monkeypatch):
|
|
"""DB temporar + app principal."""
|
|
tmp = tempfile.mkdtemp()
|
|
monkeypatch.setenv("AUTOPASS_DB_PATH", os.path.join(tmp, "t.db"))
|
|
from app.config import get_settings
|
|
get_settings.cache_clear()
|
|
from app.main import app
|
|
with TestClient(app, follow_redirects=False) as c:
|
|
from app.db import get_connection
|
|
conn = get_connection()
|
|
yield c, conn
|
|
conn.close()
|
|
get_settings.cache_clear()
|
|
|
|
|
|
def _make_account(conn, name, active=True):
|
|
from app.accounts import create_account
|
|
return create_account(conn, name, active=active)
|
|
|
|
|
|
def _insert_submission(conn, account_id, vin="WVWZZZ1KZAW000001", status="queued"):
|
|
key = f"key_{account_id}_{vin}_{status}"
|
|
payload = json.dumps({"vin": vin, "nr_inmatriculare": "B001TST",
|
|
"data_prestatie": "2026-06-01", "odometru_final": "100",
|
|
"prestatii": [{"cod_prestatie": "OE-1"}]})
|
|
conn.execute(
|
|
"INSERT INTO submissions (idempotency_key, account_id, status, payload_json) "
|
|
"VALUES (?, ?, ?, ?)",
|
|
(key, account_id, status, payload),
|
|
)
|
|
|
|
|
|
def test_counts_doar_contul_sesiunii(env, monkeypatch):
|
|
"""_status_counts scoped: contul A vede doar ale lui, nu ale lui B."""
|
|
client, conn = env
|
|
acct_a = _make_account(conn, "Cont A")
|
|
acct_b = _make_account(conn, "Cont B")
|
|
_insert_submission(conn, acct_a, vin="AAAAAAAAAAAA00001")
|
|
_insert_submission(conn, acct_a, vin="AAAAAAAAAAAA00002")
|
|
_insert_submission(conn, acct_b, vin="BBBBBBBBBBBB00001")
|
|
|
|
# Contul A vede 2 submissions
|
|
monkeypatch.setattr("app.web.routes.require_login", lambda r: acct_a)
|
|
r = client.get("/")
|
|
assert r.status_code == 200
|
|
assert "2" in r.text # 2 queued pentru A
|
|
|
|
# Contul B vede 1 submission
|
|
monkeypatch.setattr("app.web.routes.require_login", lambda r: acct_b)
|
|
r = client.get("/")
|
|
assert r.status_code == 200
|
|
|
|
|
|
def test_submissions_fragment_scoped(env, monkeypatch):
|
|
"""/_fragments/submissions arata doar submission-urile contului din sesiune.
|
|
|
|
VIN-ul e in payload_json (nu in HTML), asa ca testam dupa r.id din template.
|
|
"""
|
|
client, conn = env
|
|
acct_a = _make_account(conn, "Cont A2")
|
|
acct_b = _make_account(conn, "Cont B2")
|
|
_insert_submission(conn, acct_a, vin="AAONLY000000000VIN")
|
|
_insert_submission(conn, acct_b, vin="BBONLY000000000VIN")
|
|
sub_a = conn.execute("SELECT id FROM submissions WHERE account_id=?", (acct_a,)).fetchone()["id"]
|
|
sub_b = conn.execute("SELECT id FROM submissions WHERE account_id=?", (acct_b,)).fetchone()["id"]
|
|
|
|
monkeypatch.setattr("app.web.routes.require_login", lambda r: acct_a)
|
|
r = client.get("/_fragments/submissions")
|
|
assert r.status_code == 200
|
|
assert f"<td>{sub_a}</td>" in r.text
|
|
assert f"<td>{sub_b}</td>" not in r.text
|
|
|
|
monkeypatch.setattr("app.web.routes.require_login", lambda r: acct_b)
|
|
r = client.get("/_fragments/submissions")
|
|
assert r.status_code == 200
|
|
assert f"<td>{sub_b}</td>" in r.text
|
|
assert f"<td>{sub_a}</td>" not in r.text
|
|
|
|
|
|
def test_nelogat_redirect(monkeypatch):
|
|
"""web_auth_required=True + fara sesiune -> 303 redirect /login."""
|
|
tmp = tempfile.mkdtemp()
|
|
monkeypatch.setenv("AUTOPASS_DB_PATH", os.path.join(tmp, "t_auth.db"))
|
|
monkeypatch.setenv("AUTOPASS_WEB_AUTH_REQUIRED", "true")
|
|
from app.config import get_settings
|
|
get_settings.cache_clear()
|
|
from app.main import app
|
|
with TestClient(app, follow_redirects=False) as c:
|
|
r = c.get("/")
|
|
assert r.status_code == 303
|
|
assert "/login" in r.headers.get("location", "")
|
|
get_settings.cache_clear()
|
|
|
|
|
|
def test_banner_cont_in_asteptare(env, monkeypatch):
|
|
"""Contul cu active=0 vede banner 'in asteptare'; contul activ nu il vede."""
|
|
client, conn = env
|
|
acct_inactiv = _make_account(conn, "Cont Inactiv", active=False)
|
|
acct_activ = _make_account(conn, "Cont Activ", active=True)
|
|
|
|
monkeypatch.setattr("app.web.routes.require_login", lambda r: acct_inactiv)
|
|
r = client.get("/_fragments/banner")
|
|
assert r.status_code == 200
|
|
assert "asteptare" in r.text.lower() or "activare" in r.text.lower()
|
|
|
|
monkeypatch.setattr("app.web.routes.require_login", lambda r: acct_activ)
|
|
r = client.get("/_fragments/banner")
|
|
assert r.status_code == 200
|
|
assert "asteptare" not in r.text.lower() or "activare" not in r.text.lower()
|