Files
rar-autopass/tests/test_web_tabs.py
Claude Agent 1fbd894329 feat(web): uniformizare/standardizare UI/UX + lifecycle conturi (PRD 5.5)
Aduce toate suprafetele dashboard-ului la grila tabelului Trimiteri, muta
navigarea intr-un meniu de cont (hamburger) si da panoului admin actiuni
reale de ciclu de viata. 9 stories, 3 valuri. UI pur (reskin + reasezare)
cu O SINGURA exceptie backend: modelul de stare a contului.

- US-001 sectiunea "Ajutor" eliminata din Acasa (wayfinding redundant).
- US-002 Nomenclator la grila standard (_submissions.html ca referinta).
- US-003 macro autosend compact (Manual<->Auto). Semantica de PREZENTA
  `auto_send` (bifat->true, absent->false) NEALTERATA — compatibil cu ambele
  parsere (Form(bool) la /mapari, bool(form.get()) la import). Zero backend.
- US-004 accounts.status (pending/active/blocked/archived/deleted), migrare
  defensiva idempotenta derivata din `active`, gate worker claim_one pe
  status='active' (echivalenta active=1 <=> status='active' pastrata).
- US-005 tabel Mapari compact + panou Ajutor (<details>, proza o singura data),
  coloana "In coada".
- US-006 meniu hamburger dropdown (Cont/Integrare/Nomenclator/Admin/logout) +
  context is_authenticated/is_admin/csrf_token defensiv in base.html.
- US-007 tab-bar redus la Acasa+Mapari; rutele /_fragments/{cont,integrare,
  nomenclator} + deep-link ?tab= raman valide.
- US-008 rute admin block/archive/delete + bulk pe lista account_id,
  require_admin + CSRF + PRG, dev id=1 sarit in bulk.
- US-009 admin UI: selectie bife + master + bara bulk + kebab per-rand,
  grupare pe stare (bloc nou blocate/arhivate), nota "cont dev implicit" scoasa.

Stergere = SOFT: tombstone (status='deleted'), dar PII purjata IMEDIAT
(rar_creds_enc + chei API revocate + CUI eliberat pentru re-inregistrare),
GDPR/L.142.

VERIFY: 671 teste pass (+40). E2E browser (Playwright) a prins 2 bug-uri
invizibile la TestClient: bara bulk cu display:flex inline invingea [hidden]
(mutat in CSS .bulk-bar[hidden]); conturi arhivate cadeau sub "in asteptare"
(grupare pe status). /code-review high a prins 2 bug-uri reale: soft delete
pastra creds RAR + CUI la nesfarsit fara purjare accounts (GDPR neonorat);
apostrof in numele firmei rupea confirm() inline din kebab — ambele reparate,
plus cleanup boilerplate rute (_lifecycle_route).

Backend trimitere (worker masina stari/idempotenta/mapping) neatins, cu
exceptia gate-ului de cont. Design: docs/design/5.5-uniformizare-ui.md.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:56:05 +00:00

238 lines
9.0 KiB
Python

"""Teste US-003 (PRD 3.4): navigare cu tab-uri (shell dashboard).
TDD: testele se scriu INAINTE de implementare; la inceput pica (RED),
dupa implementare trec (GREEN).
Rute testate:
- GET / -> dashboard cu tab-bar si panou activ randat server-side
- GET /?tab=<name> -> deep-link, panoul corespunzator randat server-side
"""
from __future__ import annotations
import os
import re
import tempfile
import pytest
from starlette.testclient import TestClient
def _create_account_user(email: str = "tabs@test.com", password: str = "parolasecreta10"):
"""Creeaza cont + user. Intoarce (acct_id, user_id)."""
from app.accounts import create_account
from app.users import create_user
from app.db import get_connection
conn = get_connection()
try:
acct_id = create_account(conn, "Service Test Tabs", active=True)
user_id = create_user(conn, acct_id, email, password)
return acct_id, user_id
finally:
conn.close()
def _login(client, email: str, password: str) -> None:
"""Face login real prin HTTP si seteaza cookie-ul de sesiune pe client."""
resp = client.get("/login")
assert resp.status_code == 200
m = re.search(r'name="csrf_token"\s+value="([^"]+)"', resp.text)
if not m:
m = re.search(r'value="([^"]+)"\s+name="csrf_token"', resp.text)
assert m, "csrf_token negasit pe /login"
csrf = m.group(1)
resp = client.post("/login", data={
"email": email,
"parola": password,
"csrf_token": csrf,
})
assert resp.status_code == 303, f"Login esuat: {resp.status_code} {resp.text[:200]}"
@pytest.fixture()
def client(monkeypatch):
"""Client cu BD izolata si autentificare web activata."""
tmp = tempfile.mkdtemp()
monkeypatch.setenv("AUTOPASS_DB_PATH", os.path.join(tmp, "tabs_test.db"))
monkeypatch.setenv("AUTOPASS_WEB_AUTH_REQUIRED", "true")
from app.config import get_settings
get_settings.cache_clear()
from app.web import ratelimit
ratelimit._hits.clear() # izolare: limiterul login e global in-proces
from app.main import app
with TestClient(app, follow_redirects=False) as c:
yield c
ratelimit._hits.clear()
get_settings.cache_clear()
# ============================================================
# test_dashboard_are_tabbar
# ============================================================
def test_dashboard_are_tabbar(client):
"""US-007 (5.5): tab-bar redus la Acasa + Mapari; Cont/Integrare/Nomenclator in meniul ☰."""
_create_account_user("tabbar@test.com", "parolasecreta10")
_login(client, "tabbar@test.com", "parolasecreta10")
resp = client.get("/")
assert resp.status_code == 200
html = resp.text
assert 'role="tablist"' in html, "Lipseste role=tablist"
# Doar Acasa + Mapari sunt tab-uri (role="tab")
assert re.search(r'role="tab"[^>]*>\s*Acasa', html), "Lipseste tab-ul Acasa"
assert re.search(r'role="tab"[^>]*>\s*Mapari', html), "Lipseste tab-ul Mapari"
# Cont/Integrare/Nomenclator NU mai sunt tab-uri
for label in ("Cont", "Integrare", "Nomenclator", "Import"):
assert not re.search(rf'role="tab"[^>]*>\s*{label}\s*<', html), \
f"'{label}' nu ar mai trebui sa fie un tab separat (mutat in meniu)"
# ...dar traiesc in meniul de cont
assert 'href="/?tab=cont"' in html and 'href="/?tab=nomenclator"' in html
# ============================================================
# test_tab_implicit_acasa
# ============================================================
def test_tab_implicit_acasa(client):
"""Fara ?tab=, tab-ul Acasa are aria-selected=true."""
_create_account_user("implicit@test.com", "parolasecreta10")
_login(client, "implicit@test.com", "parolasecreta10")
resp = client.get("/")
assert resp.status_code == 200
html = resp.text
# Tab-ul activ trebuie sa aiba aria-selected="true"
assert 'aria-selected="true"' in html, "Lipseste aria-selected=true pe tab-ul activ"
# Verificam ca Acasa e cel cu aria-selected=true
# Cautam un fragment care contine atat Acasa cat si aria-selected="true" in proximitate
assert re.search(r'aria-selected="true"[^>]*>.*?Acasa|Acasa.*?aria-selected="true"', html, re.DOTALL), \
"Tab-ul Acasa nu are aria-selected=true"
# ============================================================
# test_deeplink_tab_import
# ============================================================
def test_deeplink_tab_import(client):
"""/?tab=import randeaza panoul Import server-side la full load."""
_create_account_user("deeplink@test.com", "parolasecreta10")
_login(client, "deeplink@test.com", "parolasecreta10")
resp = client.get("/?tab=import")
assert resp.status_code == 200
html = resp.text
# Panoul Import trebuie sa contina id="import-section" (din _upload.html)
assert 'id="import-section"' in html, (
"Panoul Import nu contine id='import-section' la full load cu ?tab=import"
)
# ============================================================
# test_tab_activ_randat_server_side
# ============================================================
def test_tab_activ_randat_server_side(client):
"""Panoul activ e in HTML-ul initial, nu doar cerut prin HTMX dupa load."""
_create_account_user("serverside@test.com", "parolasecreta10")
_login(client, "serverside@test.com", "parolasecreta10")
# Tab-ul implicit (Acasa) trebuie sa fie randat server-side
resp = client.get("/")
assert resp.status_code == 200
html = resp.text
# Panoul trebuie sa aiba role="tabpanel"
assert 'role="tabpanel"' in html, "Lipseste role=tabpanel in HTML initial"
# Import tab server-side
resp2 = client.get("/?tab=import")
assert resp2.status_code == 200
html2 = resp2.text
# Continutul Import trebuie sa fie randat direct, nu prin hx-trigger=load pe panoul inactiv
assert 'id="import-section"' in html2, "Panoul Import nu e randat server-side la ?tab=import"
# ============================================================
# test_fragmentele_inactive_lazy
# ============================================================
def test_fragmentele_inactive_lazy(client):
"""US-003 (3.6): Trimiterile sunt sectiune pe Acasa, nu un tab separat.
First-run (zero trimiteri): sectiunea Trimiteri (si poll-ul ei) e suprimata.
Dupa ce contul are trimiteri, sectiunea apare pe Acasa cu poll-ul ei.
"""
acct, _ = _create_account_user("lazy@test.com", "parolasecreta10")
_login(client, "lazy@test.com", "parolasecreta10")
# First-run: fara trimiteri -> niciun poll de submissions pe Acasa.
resp = client.get("/")
assert resp.status_code == 200
assert "/_fragments/submissions" not in resp.text, (
"Poll-ul de submissions nu trebuie sa apara cand contul nu are inca trimiteri"
)
# Seed o trimitere -> sectiunea Trimiteri apare pe Acasa.
from app.db import get_connection
conn = get_connection()
try:
conn.execute(
"INSERT INTO submissions (idempotency_key, account_id, status, payload_json) "
"VALUES (?, ?, 'sent', '{}')",
("k-lazy-1", acct),
)
conn.commit()
finally:
conn.close()
resp2 = client.get("/?tab=coada") # ?tab=coada cade pe Acasa, fara 404
assert resp2.status_code == 200
assert "/_fragments/submissions" in resp2.text, (
"Sectiunea Trimiteri de pe Acasa nu contine referinta la submissions"
)
# ============================================================
# test_tabbar_aria
# ============================================================
def test_tabbar_aria(client):
"""Prezenta atributelor ARIA: role=tablist/tab/tabpanel, aria-selected."""
_create_account_user("aria@test.com", "parolasecreta10")
_login(client, "aria@test.com", "parolasecreta10")
resp = client.get("/")
assert resp.status_code == 200
html = resp.text
assert 'role="tablist"' in html, "Lipseste role=tablist"
assert 'role="tab"' in html, "Lipseste role=tab"
assert 'role="tabpanel"' in html, "Lipseste role=tabpanel"
assert 'aria-selected="true"' in html, "Lipseste aria-selected=true pe tab-ul activ"
assert 'aria-selected="false"' in html, "Lipseste aria-selected=false pe tab-urile inactive"
# ============================================================
# test_fragmentele_mutate_raman_accesibile (US-007)
# ============================================================
def test_fragmentele_mutate_raman_accesibile(client):
"""US-007 (5.5): Cont/Integrare/Nomenclator s-au mutat in meniu, dar rutele de fragment
si deep-link-ul ?tab= raman valide (zero rute moarte / 404)."""
_create_account_user("frag@test.com", "parolasecreta10")
_login(client, "frag@test.com", "parolasecreta10")
for tab in ("cont", "integrare", "nomenclator"):
r_frag = client.get(f"/_fragments/{tab}")
assert r_frag.status_code == 200, f"/_fragments/{tab} a dat {r_frag.status_code}"
r_deep = client.get(f"/?tab={tab}")
assert r_deep.status_code == 200, f"/?tab={tab} a dat {r_deep.status_code}"