fix(5.19): corectii UX/retentie held (findings #2-#6 /code-review high)
#2 Filtrul "doar tinute" (held=1) devine persistent: hidden #f-held in #filtre-trimiteri sincronizat prin OOB din _submissions.html + paginare pastreaza held=1; chip "Doar tinute manual / Arata tot" ca off-switch. Param `held` schimbat la str (held= gol nu mai da 422 la coercion). #3 Banner bulk "Trimite toate (N)" extras in _bulk_held_banner.html si re-randat prin OOB (#bulk-held-banner-wrap) la fiecare reincarcare a listei -> nu mai ramane stale dupa eliberari (count revine la 0). #4 tools/carantina_held seteaza purge_after (blocked_retention_days) pe randurile carantinate -> PII nu mai sta la nesfarsit (purge_expired le poate sterge). #5 Panoul de detaliu marcheaza randul tinut (eticheta amber) si ofera buton "Trimite acum la RAR" (paritate cu randul din lista). #6 expire_held seteaza purge_after=now-1s -> randul expirat e purjabil in ACELASI ciclu (purge_expired foloseste comparatie stricta), nu la ciclul urmator. Teste noi: stickiness held + banner OOB + detaliu buton (test_web_auto_send), purge_after carantina, purge acelasi-ciclu (test_worker_held). 1541 passed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -36,13 +36,20 @@ def carantina(conn: sqlite3.Connection, dry_run: bool = False) -> int:
|
||||
"""Carantineaza randurile tinute. Intoarce numarul de randuri afectate.
|
||||
|
||||
Cu `dry_run=True` doar numara (nu modifica nimic).
|
||||
|
||||
Seteaza si `purge_after` (retentia randurilor blocate, `blocked_retention_days`): fara
|
||||
el un rand `error` iesit din `queued` NU primeste niciodata purge_after -> PII criptat
|
||||
ar sta la nesfarsit (`purge_expired` sterge doar randuri cu purge_after setat). Aliniat
|
||||
cu calea normala worker `error` (/code-review #4).
|
||||
"""
|
||||
n = _count(conn)
|
||||
if dry_run or n == 0:
|
||||
return n
|
||||
from app.config import get_settings
|
||||
days = int(get_settings().blocked_retention_days)
|
||||
conn.execute(
|
||||
"UPDATE submissions SET status='error', rar_error='ROLLBACK_QUARANTINE', "
|
||||
f"updated_at=datetime('now') WHERE {_WHERE}"
|
||||
f"purge_after=datetime('now', '+{days} days'), updated_at=datetime('now') WHERE {_WHERE}"
|
||||
)
|
||||
return n
|
||||
|
||||
|
||||
Reference in New Issue
Block a user