romfast/rar-autopass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(5.19): corectii UX/retentie held (findings #2-#6 /code-review high)

Browse Source 
#2 Filtrul "doar tinute" (held=1) devine persistent: hidden #f-held in
   #filtre-trimiteri sincronizat prin OOB din _submissions.html + paginare
   pastreaza held=1; chip "Doar tinute manual / Arata tot" ca off-switch.
   Param `held` schimbat la str (held= gol nu mai da 422 la coercion).
#3 Banner bulk "Trimite toate (N)" extras in _bulk_held_banner.html si
   re-randat prin OOB (#bulk-held-banner-wrap) la fiecare reincarcare a listei
   -> nu mai ramane stale dupa eliberari (count revine la 0).
#4 tools/carantina_held seteaza purge_after (blocked_retention_days) pe randurile
   carantinate -> PII nu mai sta la nesfarsit (purge_expired le poate sterge).
#5 Panoul de detaliu marcheaza randul tinut (eticheta amber) si ofera buton
   "Trimite acum la RAR" (paritate cu randul din lista).
#6 expire_held seteaza purge_after=now-1s -> randul expirat e purjabil in ACELASI
   ciclu (purge_expired foloseste comparatie stricta), nu la ciclul urmator.

Teste noi: stickiness held + banner OOB + detaliu buton (test_web_auto_send),
purge_after carantina, purge acelasi-ciclu (test_worker_held). 1541 passed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Claude Agent
2026-07-06 11:19:00 +00:00
parent 789e3f54be
commit eade702a52
10 changed files with 242 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/test_worker_held.py
View File

@@ -178,7 +178,8 @@ def test_expire_held_ignora_rand_neted_vechi(env):
def test_expire_held_apoi_purge_sterge_randul(env):
"""Lant complet: expire_held (purge_after ~now) -> purge_expired sterge randul (PII purjat)."""
"""Lant complet ACELASI CICLU: expire_held (purge_after=now-1s) -> purge_expired
sterge randul imediat (PII purjat), fara sa astepte ciclul urmator (fix /code-review #6)."""
from app.accounts import create_account
from app.worker.__main__ import expire_held, purge_expired
@@ -188,17 +189,9 @@ def test_expire_held_apoi_purge_sterge_randul(env):
conn.execute("UPDATE submissions SET created_at=datetime('now','-100 days') WHERE id=?", (sid,))
assert expire_held(conn, settings) == 1
# purge_after=datetime('now') (moment expirarii). La URMATORUL ciclu de purjare
# (o data pe ora) purge_after < now -> se sterge. Simulam trecerea timpului
# (>= 1s) verificand ca purge_after e deja in trecutul acelui ciclu ulterior.
assert conn.execute(
"SELECT purge_after < datetime('now','+1 second') AS ok FROM submissions WHERE id=?",
(sid,),
).fetchone()["ok"] == 1
conn.execute(
"UPDATE submissions SET purge_after=datetime('now','-1 second') WHERE id=?", (sid,)
)
# expire_held seteaza purge_after=now-1s -> purge_expired (purge_after < now strict) il
# sterge in ACELASI ciclu, fara nudge manual de timp.
stats = purge_expired(conn)
assert stats["submissions_purged"] >= 1
assert _row(conn, sid) is None, "randul expirat trebuia sters de purge_expired la ciclul ulterior"
assert _row(conn, sid) is None, "randul expirat trebuia sters de purge_expired in acelasi ciclu"