fix(5.19): corectii UX/retentie held (findings #2-#6 /code-review high)

#2 Filtrul "doar tinute" (held=1) devine persistent: hidden #f-held in
   #filtre-trimiteri sincronizat prin OOB din _submissions.html + paginare
   pastreaza held=1; chip "Doar tinute manual / Arata tot" ca off-switch.
   Param `held` schimbat la str (held= gol nu mai da 422 la coercion).
#3 Banner bulk "Trimite toate (N)" extras in _bulk_held_banner.html si
   re-randat prin OOB (#bulk-held-banner-wrap) la fiecare reincarcare a listei
   -> nu mai ramane stale dupa eliberari (count revine la 0).
#4 tools/carantina_held seteaza purge_after (blocked_retention_days) pe randurile
   carantinate -> PII nu mai sta la nesfarsit (purge_expired le poate sterge).
#5 Panoul de detaliu marcheaza randul tinut (eticheta amber) si ofera buton
   "Trimite acum la RAR" (paritate cu randul din lista).
#6 expire_held seteaza purge_after=now-1s -> randul expirat e purjabil in ACELASI
   ciclu (purge_expired foloseste comparatie stricta), nu la ciclul urmator.

Teste noi: stickiness held + banner OOB + detaliu buton (test_web_auto_send),
purge_after carantina, purge acelasi-ciclu (test_worker_held). 1541 passed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

tests/test_carantina_held.py

@@ -63,6 +63,12 @@ def test_carantineaza_rand_tinut(env, capsys):
     r = _row(conn, sid)
     assert r["status"] == "error"
     assert r["rar_error"] == "ROLLBACK_QUARANTINE"
+    # /code-review #4: randul carantinat primeste purge_after (altfel PII ar sta la nesfarsit,
+    # purge_expired sterge doar randuri cu purge_after setat).
+    assert r["purge_after"] is not None
+    assert conn.execute(
+        "SELECT purge_after > datetime('now') AS ok FROM submissions WHERE id=?", (sid,)
+    ).fetchone()["ok"] == 1
 
 
 def test_dry_run_nu_modifica(env, capsys):

tests/test_web_auto_send.py

@@ -345,3 +345,86 @@ def test_audit_held_eliberat_bulk(client):
     client.post("/trimite-toate", data={"csrf_token": csrf})
     evs = _events(aid, "held_eliberat")
     assert len(evs) >= 1
+
+
+# --------------------------------------------------------------------------- #
+# /code-review (fix findings #2/#3/#5): stickiness filtru held, banner OOB,    #
+# afordanta de eliberare in panoul de detaliu.                                 #
+# --------------------------------------------------------------------------- #
+
+def test_fragment_held_gol_nu_da_422(client):
+    """Formularul include mereu `held` (gol cand filtrul e oprit) -> `held=` NU trebuie 422."""
+    aid = _account_user("k1@test.com")
+    _login(client, "k1@test.com")
+    _ins(aid, "queued", held=0)
+    resp = client.get("/_fragments/submissions?held=")
+    assert resp.status_code == 200, resp.text[:200]
+
+
+def test_fragment_held_1_filtreaza_si_persista_oob(client):
+    """?held=1 -> doar randuri tinute + OOB #f-held=1 (sticky la reincarcari) + chip 'Arata tot'."""
+    aid = _account_user("k2@test.com")
+    _login(client, "k2@test.com")
+    sid_tinut = _ins(aid, "queued", held=1)
+    _ins(aid, "sent", held=0)
+    resp = client.get("/_fragments/submissions?held=1")
+    assert resp.status_code == 200
+    # OOB sincronizeaza filtrul in form ca sa nu se piarda la trimiteriChanged/paginare.
+    assert re.search(r'id="f-held"[^>]*value="1"[^>]*hx-swap-oob', resp.text) or \
+           re.search(r'id="f-held"[^>]*hx-swap-oob[^>]*value="1"', resp.text), resp.text[:400]
+    assert "Arata tot" in resp.text
+    # Paginare (daca apare) pastreaza held=1.
+    if "Paginare" in resp.text:
+        assert "held=1" in resp.text
+
+
+def test_fragment_lista_curata_reseteaza_f_held(client):
+    """Reincarcarea listei fara filtre (dupa actiune) reseteaza #f-held la gol via OOB."""
+    aid = _account_user("k3@test.com")
+    csrf = _login(client, "k3@test.com")
+    sid = _ins(aid, "queued", held=1)
+    # trimite-acum -> _render_submissions (fara filtre) -> OOB f-held=""
+    resp = client.post(f"/trimitere/{sid}/trimite-acum", data={"csrf_token": csrf})
+    assert resp.status_code == 200
+    assert re.search(r'id="f-held"[^>]*value=""[^>]*hx-swap-oob', resp.text) or \
+           re.search(r'id="f-held"[^>]*hx-swap-oob[^>]*value=""', resp.text), resp.text[:400]
+
+
+def test_banner_bulk_dispare_dupa_eliberare(client):
+    """Banner 'Trimite toate (N)' e OOB (#bulk-held-banner-wrap): dupa eliberarea tuturor
+    randurilor tinute, wrapper-ul revine gol (fara buton) — nu mai ramane stale (#3)."""
+    aid = _account_user("k4@test.com")
+    csrf = _login(client, "k4@test.com")
+    _ins(aid, "queued", held=1)
+    _ins(aid, "queued", held=1)
+    # Inainte: fragmentul contine bannerul cu butonul.
+    r0 = client.get("/_fragments/submissions")
+    assert 'id="bulk-held-banner-wrap"' in r0.text
+    assert "Trimite toate" in r0.text
+    # Elibereaza toate -> wrapper OOB re-randat gol (fara buton).
+    r1 = client.post("/trimite-toate", data={"csrf_token": csrf})
+    assert r1.status_code == 200
+    assert 'id="bulk-held-banner-wrap"' in r1.text
+    assert "Trimite toate" not in r1.text
+
+
+def test_detaliu_rand_tinut_are_buton_trimite_acum(client):
+    """Panoul de detaliu al unui rand tinut (queued AND held=1) arata eticheta manuala +
+    buton 'Trimite acum la RAR' (#5)."""
+    aid = _account_user("k5@test.com")
+    _login(client, "k5@test.com")
+    sid = _ins(aid, "queued", held=1)
+    resp = client.get(f"/_fragments/trimitere/{sid}")
+    assert resp.status_code == 200, resp.text[:200]
+    assert "Trimite acum la RAR" in resp.text
+    assert f"/trimitere/{sid}/trimite-acum" in resp.text
+
+
+def test_detaliu_rand_queued_neted_fara_buton(client):
+    """Un rand queued NEtinut (held=0) NU arata butonul de eliberare in detaliu."""
+    aid = _account_user("k6@test.com")
+    _login(client, "k6@test.com")
+    sid = _ins(aid, "queued", held=0)
+    resp = client.get(f"/_fragments/trimitere/{sid}")
+    assert resp.status_code == 200
+    assert "Trimite acum la RAR" not in resp.text

tests/test_worker_held.py

@@ -178,7 +178,8 @@ def test_expire_held_ignora_rand_neted_vechi(env):
 
 
 def test_expire_held_apoi_purge_sterge_randul(env):
-    """Lant complet: expire_held (purge_after ~now) -> purge_expired sterge randul (PII purjat)."""
+    """Lant complet ACELASI CICLU: expire_held (purge_after=now-1s) -> purge_expired
+    sterge randul imediat (PII purjat), fara sa astepte ciclul urmator (fix /code-review #6)."""
     from app.accounts import create_account
     from app.worker.__main__ import expire_held, purge_expired
 
@@ -188,17 +189,9 @@ def test_expire_held_apoi_purge_sterge_randul(env):
     conn.execute("UPDATE submissions SET created_at=datetime('now','-100 days') WHERE id=?", (sid,))
 
     assert expire_held(conn, settings) == 1
-    # purge_after=datetime('now') (moment expirarii). La URMATORUL ciclu de purjare
-    # (o data pe ora) purge_after < now -> se sterge. Simulam trecerea timpului
-    # (>= 1s) verificand ca purge_after e deja in trecutul acelui ciclu ulterior.
-    assert conn.execute(
-        "SELECT purge_after < datetime('now','+1 second') AS ok FROM submissions WHERE id=?",
-        (sid,),
-    ).fetchone()["ok"] == 1
-    conn.execute(
-        "UPDATE submissions SET purge_after=datetime('now','-1 second') WHERE id=?", (sid,)
-    )
+    # expire_held seteaza purge_after=now-1s -> purge_expired (purge_after < now strict) il
+    # sterge in ACELASI ciclu, fara nudge manual de timp.
     stats = purge_expired(conn)
 
     assert stats["submissions_purged"] >= 1
-    assert _row(conn, sid) is None, "randul expirat trebuia sters de purge_expired la ciclul ulterior"
+    assert _row(conn, sid) is None, "randul expirat trebuia sters de purge_expired in acelasi ciclu"