romfast/rar-autopass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(5.19): corectii UX/retentie held (findings #2-#6 /code-review high)

Browse Source 
#2 Filtrul "doar tinute" (held=1) devine persistent: hidden #f-held in
   #filtre-trimiteri sincronizat prin OOB din _submissions.html + paginare
   pastreaza held=1; chip "Doar tinute manual / Arata tot" ca off-switch.
   Param `held` schimbat la str (held= gol nu mai da 422 la coercion).
#3 Banner bulk "Trimite toate (N)" extras in _bulk_held_banner.html si
   re-randat prin OOB (#bulk-held-banner-wrap) la fiecare reincarcare a listei
   -> nu mai ramane stale dupa eliberari (count revine la 0).
#4 tools/carantina_held seteaza purge_after (blocked_retention_days) pe randurile
   carantinate -> PII nu mai sta la nesfarsit (purge_expired le poate sterge).
#5 Panoul de detaliu marcheaza randul tinut (eticheta amber) si ofera buton
   "Trimite acum la RAR" (paritate cu randul din lista).
#6 expire_held seteaza purge_after=now-1s -> randul expirat e purjabil in ACELASI
   ciclu (purge_expired foloseste comparatie stricta), nu la ciclul urmator.

Teste noi: stickiness held + banner OOB + detaliu buton (test_web_auto_send),
purge_after carantina, purge acelasi-ciclu (test_worker_held). 1541 passed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Claude Agent
2026-07-06 11:19:00 +00:00
parent 789e3f54be
commit eade702a52
10 changed files with 242 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/worker/__main__.py
View File

@@ -149,8 +149,12 @@ def expire_held(conn, settings: Settings) -> int:
blocat -> altfel NU primeste `purge_after` -> PII criptat ar sta la nesfarsit.
Le trece la `error`/`TINUT_EXPIRAT` (terminal) si seteaza `purge_after` DIRECT la
momentul expirarii (NU lasa retentia de 30z a randurilor blocate sa se adauge; altfel
viata reala = 90 + 30 = 120 zile, nu 90). Randul devine imediat purjabil de
`purge_expired` (purge_after < now) la urmatorul ciclu.
viata reala = 90 + 30 = 120 zile, nu 90). `purge_after` e setat cu o secunda IN TRECUT
(`datetime('now','-1 second')`): `purge_expired` foloseste comparatie STRICTA
(`purge_after < datetime('now')`), iar `datetime('now')` are rezolutie de o secunda —
cu `purge_after=now` cele doua ar fi egale in acelasi ciclu si randul NU s-ar purja
decat la ciclul urmator (~1h de PII in plus). Cu `-1 second` randul e purjabil IMEDIAT
in acelasi ciclu de purjare (US-008 inchide gaura strict).
Intoarce numarul de randuri expirate.
"""
@@ -159,7 +163,7 @@ def expire_held(conn, settings: Settings) -> int:
cutoff = f"-{days} days"
cur = conn.execute(
"UPDATE submissions SET status='error', rar_error='TINUT_EXPIRAT', "
"purge_after=datetime('now'), sending_since=NULL, updated_at=datetime('now') "
"purge_after=datetime('now', '-1 second'), sending_since=NULL, updated_at=datetime('now') "
"WHERE status='queued' AND held=1 AND created_at < datetime('now', ?)",
(cutoff,),
)
@@ -562,7 +566,8 @@ def run() -> int:
now_ts = time.time()
if now_ts - _last_purge_time >= _PURGE_INTERVAL_S:
# Expira intai randurile tinute imbatranite (US-008), apoi purjeaza:
# un rand expirat cu purge_after=now devine imediat purjabil in acelasi ciclu.
# expire_held seteaza purge_after=now-1s -> randul e purjabil IMEDIAT in
# acelasi ciclu (purge_expired foloseste comparatie stricta purge_after<now).
expired = expire_held(conn, settings)
if expired:
_wlog(conn, "held_expirat",