romfast/rar-autopass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: comentarii strict functionale, fara referinte PRD/stories

Browse Source 
Curatare globala a comentariilor si docstring-urilor (app, tools, teste,
scripturi): eliminate referintele la PRD-uri, US-xxx, task-uri istorice si
review-uri; pastrata doar informatia functionala, formulata scurt. Regula
adaugata in CLAUDE.md (sectiunea Stil). Fara modificari de cod sau comportament.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Claude Agent
2026-07-06 13:48:38 +00:00
parent 86408887e5
commit 44f261e269
226 changed files with 1313 additions and 1760 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
tests/test_web_mapare_din_chip.py
View File

@@ -1,12 +1,10 @@
"""Teste TDD US-009 (PRD 5.15): salvare mapare din chip + cleanup (B) select redundant.
"""Teste pentru salvarea maparii direct din chip.
RED -> implementare -> GREEN.
AC-uri verificate:
Verifica:
- Endpoint /trimitere/{id}/salveaza-regula-chip salveaza regula via save_mapping+reresolve_account.
- Re-rezolvarea deblocheaza si submission-uri frate cu aceeasi operatie (batch_id IS NULL).
- Editarea one-off prin /corecteaza nu forteaza salvarea regulii in operations_mapping.
- Cleanup (B): detaliu needs_data NU mai contine <select name="cod_prestatie"> simultan cu chips.
- Detaliu needs_data NU mai contine <select name="cod_prestatie"> simultan cu chips.
"""
from __future__ import annotations
@@ -124,14 +122,11 @@ def _get_rule(acct: int, op: str):
# --------------------------------------------------------------------------- #
# Test 1: Salvare regula din chip (US-009 AC1) #
# Test 1: Salvare regula din chip #
# --------------------------------------------------------------------------- #
def test_salveaza_regula_din_chip(client):
"""US-009 AC1: POST /trimitere/{id}/salveaza-regula-chip -> save_mapping + reresolve.
RED: endpoint-ul nu exista inca; trebuie creat cu reuse EXACT save_mapping+reresolve_account.
"""
"""POST /trimitere/{id}/salveaza-regula-chip -> save_mapping + reresolve."""
acct = _create_account_user("save.chip@test.com")
_login(client, "save.chip@test.com")
_seed_cod("OE-1", "Schimb ulei motor")
@@ -146,7 +141,7 @@ def test_salveaza_regula_din_chip(client):
})
csrf = _csrf(client)
# Salveaza regula din chip (endpoint nou US-009)
# Salveaza regula din chip
resp = client.post(
f"/trimitere/{sid}/salveaza-regula-chip",
data={
@@ -175,18 +170,15 @@ def test_salveaza_regula_din_chip(client):
)
# Nota: mesajul de confirmare ("Regula salvata...") e in context dar flash-ul
# e randat in sectiunea editabila; dupa re-rezolvare la queued, detaliu e read-only.
# Verificarile esentiale (rule in DB + status queued) sunt de ajuns pentru US-009 AC1.
# --------------------------------------------------------------------------- #
# Test 2: Re-rezolvare deblocheaza submission frate (US-009 AC2) #
# Test 2: Re-rezolvare deblocheaza submission frate #
# --------------------------------------------------------------------------- #
def test_reresolve_deblocheaza_frate(client):
"""US-009 AC2: salvarea regulii din chip deblocheaza si alt submission needs_mapping
"""Salvarea regulii din chip deblocheaza si alt submission needs_mapping
cu aceeasi operatie (canal API — batch_id IS NULL → reresolve_account scoped null).
RED: endpoint-ul nu exista; dupa implementare, reresolve_account re-rezolva ambele.
"""
acct = _create_account_user("frate.deblocat@test.com")
_login(client, "frate.deblocat@test.com")
@@ -238,16 +230,14 @@ def test_reresolve_deblocheaza_frate(client):
# --------------------------------------------------------------------------- #
# Test 3: Editare one-off nu forteaza salvarea regulii (US-009 AC3) #
# Test 3: Editare one-off nu forteaza salvarea regulii #
# --------------------------------------------------------------------------- #
def test_optional_nu_forteaza(client):
"""US-009 AC3: editarea ramane one-off daca userul nu apeleaza salveaza-regula-chip.
"""Editarea ramane one-off daca userul nu apeleaza salveaza-regula-chip.
POST-ul la /corecteaza (fara /salveaza-regula-chip) trebuie sa functioneze normal;
nicio regula nu se salveaza automat in operations_mapping.
RED: daca /corecteaza ar salva automat regula (nedorit), testul pica.
"""
acct = _create_account_user("optional.oneoff@test.com")
_login(client, "optional.oneoff@test.com")
@@ -279,24 +269,21 @@ def test_optional_nu_forteaza(client):
assert rule is None, (
f"Regula a fost salvata AUTOMAT in operations_mapping (nu ar trebui!): "
f"op={op!r}, rule={dict(rule) if rule else None}. "
"Salvarea regulii trebuie sa fie OPTIONALA (US-009 AC3)."
"Salvarea regulii trebuie sa fie OPTIONALA."
)
# --------------------------------------------------------------------------- #
# Test 4: Cleanup (B) — <select name="cod_prestatie"> redundant eliminat #
# Test 4: <select name="cod_prestatie"> redundant eliminat #
# --------------------------------------------------------------------------- #
def test_fara_select_vechi_redundant(client):
"""Cleanup (B): detaliu needs_data NU mai contine <select name='cod_prestatie'>.
"""Detaliu needs_data NU mai contine <select name='cod_prestatie'>.
Dupa cleanup, formularul editabil foloseste NUMAI chips (hidden inputs cod_prestatie),
Formularul editabil foloseste NUMAI chips (hidden inputs cod_prestatie),
fara vechiul select dublu. Chips functioneaza ca singura sursa de cod_prestatie.
Nota: <select name="cod_prestatie"> RAMANE in formularul /repune pentru starea error
(neschimbat — nu e subiectul cleanup-ului B).
RED: inainte de cleanup, atat selectul cat si chips emit cod_prestatie → dublu.
Nota: <select name="cod_prestatie"> RAMANE in formularul /repune pentru starea error.
"""
acct = _create_account_user("no.select.vechi@test.com")
_login(client, "no.select.vechi@test.com")
@@ -334,7 +321,7 @@ def test_fara_select_vechi_redundant(client):
assert not select_cod_prestatie, (
"Sectiunea editabila needs_data NU trebuie sa mai contina "
"<select name='cod_prestatie'>. "
"Chips-urile (hidden inputs) il inlocuiesc (cleanup B, US-009). "
"Chips-urile (hidden inputs) il inlocuiesc. "
f"Gasit: {select_cod_prestatie.group(0) if select_cod_prestatie else 'N/A'}. "
f"html[:800]={html[:800]}"
)