romfast/rar-autopass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: comentarii strict functionale, fara referinte PRD/stories

Browse Source 
Curatare globala a comentariilor si docstring-urilor (app, tools, teste,
scripturi): eliminate referintele la PRD-uri, US-xxx, task-uri istorice si
review-uri; pastrata doar informatia functionala, formulata scurt. Regula
adaugata in CLAUDE.md (sectiunea Stil). Fara modificari de cod sau comportament.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Claude Agent
2026-07-06 13:48:38 +00:00
parent 86408887e5
commit 44f261e269
226 changed files with 1313 additions and 1760 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
tests/test_mapare_integrare_l14.py
View File

@@ -1,11 +1,11 @@
"""TDD L14-S6 — Integrare Layer 2/3 in editor (suggestion-only, DUPA 5.15).
"""Integrare sugestii de mapare in editor (suggestion-only).
Scenarii acoperite:
- F1-regression CRITIC: SILVER/shared GOLD NU auto-trimit (resolve_prestatii neschimbat)
- pending_unmapped include sugestie GOLD partajat > SILVER > embeddings (precedenta Eng-F2)
- SILVER/shared GOLD NU auto-trimit (resolve_prestatii neschimbat)
- pending_unmapped include sugestie GOLD partajat > SILVER > embeddings
- record_human_validation apelat la confirmare umana (POST /mapari -> shared_mappings)
- Degradare gratioasa cand embeddings indisponibil (mock is_available=False)
- Separare structurala #13: resolve_prestatii/load_mapping NU citesc tabelele de sugestii
- Separare structurala: resolve_prestatii/load_mapping NU citesc tabelele de sugestii
"""
from __future__ import annotations
@@ -62,11 +62,11 @@ def client(env):
# --------------------------------------------------------------------------- #
# F1-regression CRITIC: SILVER/shared GOLD NU auto-trimit #
# Regresie critica: SILVER/shared GOLD NU auto-trimit #
# --------------------------------------------------------------------------- #
def test_f1_silver_nu_auto_trimite(conn):
"""CRITICAL F1: un cod in SILVER (mapping_suggestions) NU produce auto-trimitere.
"""Un cod in SILVER (mapping_suggestions) NU produce auto-trimitere.
resolve_prestatii cu mapping gol + SILVER existent -> operatie ramane nemapata.
Submissionul ar ramane needs_mapping, NU queued.
@@ -84,13 +84,13 @@ def test_f1_silver_nu_auto_trimite(conn):
[{"cod_op_service": "OP-REV", "denumire": "Revizie periodica"}],
{}, # operations_mapping gol
)
# Operatia ramane nemapata (SILVER nu e in resolve, #13)
# Operatia ramane nemapata (SILVER nu e in resolve)
assert resolved[0]["cod_prestatie"] is None
assert len(unmapped) == 1
def test_f1_shared_gold_nu_auto_trimite(conn):
"""CRITICAL F1: un cod in shared_mappings (GOLD partajat) NU produce auto-trimitere.
"""Un cod in shared_mappings (GOLD partajat) NU produce auto-trimitere.
resolve_prestatii cu mapping gol + shared GOLD existent -> operatie ramane nemapata.
"""
@@ -105,13 +105,13 @@ def test_f1_shared_gold_nu_auto_trimite(conn):
[{"cod_op_service": "OP-ULEI", "denumire": "Schimb ulei motor"}],
{}, # operations_mapping gol
)
# Operatia ramane nemapata (GOLD partajat nu e in resolve, #13)
# Operatia ramane nemapata (GOLD partajat nu e in resolve)
assert resolved[0]["cod_prestatie"] is None
assert len(unmapped) == 1
def test_f1_load_mapping_nu_citeste_shared_gold(conn):
"""Separare #13: load_mapping NU returneaza coduri din shared_mappings."""
"""load_mapping NU returneaza coduri din shared_mappings."""
from app.shared_store import record_human_validation
from app.mapping import load_mapping
@@ -175,7 +175,7 @@ def test_enrich_include_silver(conn):
def test_enrich_precedenta_gold_peste_silver(conn):
"""Precedenta Eng-F2: GOLD partajat castiga fata de SILVER cand ambele exista."""
"""GOLD partajat castiga fata de SILVER cand ambele exista."""
from app.shared_store import seed_suggestions, record_human_validation
from app.mapping import enrich_suggestions
@@ -197,7 +197,7 @@ def test_enrich_precedenta_gold_peste_silver(conn):
def test_enrich_degradare_embeddings_indisponibil(conn, monkeypatch):
"""Degradare gratioasa (#16b): cand embeddings nu e disponibil, nu eroare."""
"""Degradare gratioasa: cand embeddings nu e disponibil, nu eroare."""
import app.embeddings as emb_mod
monkeypatch.setattr(emb_mod, "is_available", lambda: False)
@@ -210,7 +210,7 @@ def test_enrich_degradare_embeddings_indisponibil(conn, monkeypatch):
def test_enrich_corpus_gol_nu_incarca_modelul(conn, monkeypatch):
"""Bug fix (code-review): enrich_suggestions NU lazy-load-eaza modelul de 220MB
"""enrich_suggestions NU lazy-load-eaza modelul de 220MB
cand corpus-ul embeddings e gol.
Implementarea veche apela `is_available()` neconditionat -> `_get_engine()` ->
@@ -258,7 +258,7 @@ class _FakeEmbedBackend:
def test_embeddings_functional_cand_flag_activ(conn, monkeypatch):
"""PRD #15: cu AUTOPASS_EMBEDDINGS_ENABLED=true, embeddings produce efectiv o sugestie.
"""Cu AUTOPASS_EMBEDDINGS_ENABLED=true, embeddings produce efectiv o sugestie.
Wire-uieste ensure_embeddings_corpus (corpus din nomenclator) + enrich_suggestions.
Backend injectat (determinist) -> nu incarca modelul real de 230MB.
@@ -272,7 +272,7 @@ def test_embeddings_functional_cand_flag_activ(conn, monkeypatch):
get_settings.cache_clear()
monkeypatch.setattr(emb_mod, "_engine", EmbeddingEngine(backend=_FakeEmbedBackend()))
# Corpusul sursa = mapping_suggestions (SILVER) -- PRD 5.18 US-005.
# Corpusul sursa = mapping_suggestions (SILVER).
# (Inainte era nomenclator_rar; migrat la mapping_suggestions ca k-NN sa
# opereze pe exemple reale etichetate, nu pe categorii generice RAR.)
conn.execute(
@@ -362,7 +362,7 @@ def test_pending_unmapped_include_sugestie_principala(conn):
assert len(pending) == 1
entry = pending[0]
# sugestie_principala adaugat de enrich_suggestions (L14-S6)
# sugestie_principala adaugat de enrich_suggestions
assert "sugestie_principala" in entry
sp = entry["sugestie_principala"]
assert sp is not None
@@ -434,7 +434,7 @@ def test_record_human_validation_la_post_mapari(env, client):
finally:
conn_setup.close()
# POST /mapari cu denumire (L14-S6: form include denumire hidden)
# POST /mapari cu denumire (form include denumire hidden)
resp = client.post(
"/mapari",
data={
@@ -511,7 +511,7 @@ def test_record_human_validation_la_mapeaza_inline(env, client):
def test_mapare_salvata_fara_denumire_nu_polueaza_gold(env, client):
"""Bug fix (code-review 5.15): editarea unei mapari salvate FARA denumire NU scrie
"""Editarea unei mapari salvate FARA denumire NU scrie
o intrare bogus in GOLD partajat (cheiata pe cod_op_service in loc de denumire umana).
Formularul din _mapari.html nu trimite denumire; vechiul fallback `denumire or
@@ -554,11 +554,11 @@ def test_mapare_salvata_fara_denumire_nu_polueaza_gold(env, client):
# --------------------------------------------------------------------------- #
# Separare structurala #13 (redundant cu test_shared_store dar explicit L14) #
# Separare structurala (redundant cu test_shared_store dar explicit) #
# --------------------------------------------------------------------------- #
def test_separare_silver_din_resolve_prestatii():
"""#13: resolve_prestatii nu citeste mapping_suggestions (SILVER)."""
"""resolve_prestatii nu citeste mapping_suggestions (SILVER)."""
from app.mapping import resolve_prestatii
# Apelam fara conn (pur) — SILVER nu e parametru si nu e accesat
@@ -571,7 +571,7 @@ def test_separare_silver_din_resolve_prestatii():
def test_separare_shared_gold_din_resolve_prestatii():
"""#13: resolve_prestatii nu citeste shared_mappings (GOLD partajat)."""
"""resolve_prestatii nu citeste shared_mappings (GOLD partajat)."""
from app.mapping import resolve_prestatii
resolved, unmapped = resolve_prestatii(