romfast/rar-autopass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: comentarii strict functionale, fara referinte PRD/stories

Browse Source 
Curatare globala a comentariilor si docstring-urilor (app, tools, teste,
scripturi): eliminate referintele la PRD-uri, US-xxx, task-uri istorice si
review-uri; pastrata doar informatia functionala, formulata scurt. Regula
adaugata in CLAUDE.md (sectiunea Stil). Fara modificari de cod sau comportament.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Claude Agent
2026-07-06 13:48:38 +00:00
parent 86408887e5
commit 44f261e269
226 changed files with 1313 additions and 1760 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
tests/test_import_e2e.py
View File

@@ -1,16 +1,16 @@
"""Teste E2E T15 — integrare import->commit->worker (RAR mock) + masina de stari + failure registry.
"""Teste E2E: integrare import->commit->worker (RAR mock) + masina de stari + failure registry.
Acopera (plan T15, sect.12):
Acopera:
- Scenariul 1: upload xlsx/csv -> column-mapping -> preview -> commit N
-> worker process_one (MockRar) -> submission FINALIZATA cu id_prezentare.
- Scenariul 2: re-upload acelasi continut -> preview marcheaza already_sent
(NU al doilea FINALIZATA dupa commit).
- Scenariul 3: coada MIXTA API(creds efemere)+web(creds durabile per-env, US-013):
- Scenariul 3: coada mixta API(creds efemere)+web(creds durabile per-env):
dupa login + purjare creds efemere, submission-urile web tot se trimit
prin fallback accounts.rar_creds_{env}_enc (T1/Voce#5).
- Masina de stari (sect. 6): tranzitii queued->sending->sent/requeued/error.
- Failure registry (sect. 8): 400/403/503+reconciliere.
- T16: purge_expired + purge_after setat la commit.
prin fallback accounts.rar_creds_{env}_enc.
- Masina de stari: tranzitii queued->sending->sent/requeued/error.
- Failure registry: 400/403/503+reconciliere.
- Purjare: purge_expired + purge_after setat la commit.
"""
from __future__ import annotations
@@ -451,10 +451,10 @@ class TestE2EAlreadySent:
class TestE2EMixedQueue:
def test_coada_mixta_ambele_trimise(self, env, monkeypatch):
"""Scenariul 3 (T1/Voce#5): API (creds efemere) + web (canal import, fara creds pe submission).
"""Scenariul 3: API (creds efemere) + web (canal import, fara creds pe submission).
Dupa purjarea creds efemere ale canalului API (la primul login), submission-urile
import (web) tot se trimit prin fallback accounts.rar_creds_{env}_enc (US-013, per-env).
import (web) tot se trimit prin fallback accounts.rar_creds_{env}_enc, per-env.
Verificam ca ambele submission-uri ajung la status='sent'.
"""
import app.worker.__main__ as w
@@ -486,11 +486,11 @@ class TestE2EMixedQueue:
assert r_api.status_code == 200, r_api.text
sub_api_id = r_api.json()["results"][0]["submission_id"]
# 3. Seteaza creds durabile in accounts per-env (US-013, canal web fallback)
# 3. Seteaza creds durabile in accounts per-env (canal web fallback)
conn = get_connection()
try:
web_creds_enc = encrypt_creds({"email": "web@test.ro", "password": "pass_web"})
# US-013: scrie in slotul per-env test (rar_env default = 'test')
# scrie in slotul per-env test (rar_env default = 'test')
conn.execute(
"UPDATE accounts SET rar_creds_test_enc=?, rar_test_enabled=1 WHERE id=1",
(web_creds_enc,),
@@ -522,7 +522,7 @@ class TestE2EMixedQueue:
try:
processed = 0
# Drena coada simuland bucla worker completa (T1/D4: creds efemere + fallback per-env)
# Drena coada simuland bucla worker completa: creds efemere + fallback per-env
for _ in range(10): # limita de siguranta
claimed = w.claim_one(conn)
if claimed is None:
@@ -532,7 +532,7 @@ class TestE2EMixedQueue:
account_id = claimed["account_id"]
rar_env = claimed.get("rar_env", "test")
# T1/D4: creds din submission (API efemer) OR fallback per-env (US-013)
# creds din submission (API efemer) OR fallback per-env
creds = w._creds_for(claimed, settings) or w._creds_from_account(conn, account_id, rar_env=rar_env)
assert creds is not None, \
f"Creds None pentru submission {sid} — fallback durabil trebuie sa existe"
@@ -566,9 +566,9 @@ class TestE2EMixedQueue:
assert mock_rar.post_calls == 2
def test_purjare_creds_efemere_nu_sterge_durabile(self, env, monkeypatch):
"""T1/Gate purjare (OV-5): dupa login, submissions.rar_creds_enc sterse DAR per-env INTACT.
"""Dupa login, submissions.rar_creds_enc sterse DAR per-env INTACT.
Worker sterge DOAR submissions.rar_creds_enc (efemere), NU accounts.rar_creds_{env}_enc (durabile, US-013).
Worker sterge DOAR submissions.rar_creds_enc (efemere), NU accounts.rar_creds_{env}_enc (durabile).
"""
import app.worker.__main__ as w
from app.crypto import encrypt_creds
@@ -590,7 +590,7 @@ class TestE2EMixedQueue:
assert r_api.status_code == 200
sub_id = r_api.json()["results"][0]["submission_id"]
# Seteaza creds durabile pe cont (slotul per-env, US-013)
# Seteaza creds durabile pe cont (slotul per-env)
conn = get_connection()
try:
web_creds_enc = encrypt_creds({"email": "web@test.ro", "password": "pass_web"})
@@ -634,7 +634,7 @@ class TestE2EMixedQueue:
# =========================================================================== #
# Masina de stari (sect. 6 din plan): tranzitii explicite per submission #
# Masina de stari: tranzitii explicite per submission #
# =========================================================================== #
class TestStateMachine:
@@ -797,7 +797,7 @@ class TestStateMachine:
# =========================================================================== #
# Registrul de esecuri (sect. 8): tipuri de eroare RAR si recuperare #
# Registrul de esecuri: tipuri de eroare RAR si recuperare #
# =========================================================================== #
class TestFailureRegistry:
@@ -929,12 +929,12 @@ class TestFailureRegistry:
# =========================================================================== #
# T16 — Purjare (purge_expired + purge_after setat la commit) #
# Purjare (purge_expired + purge_after setat la commit) #
# =========================================================================== #
class TestPurjare:
def test_purge_expired_sterge_sent_expirate(self, env):
"""T16: purge_expired sterge submissions cu status='sent' si purge_after in trecut."""
"""purge_expired sterge submissions cu status='sent' si purge_after in trecut."""
from app.worker.__main__ import purge_expired
client, get_connection, get_settings = env
@@ -958,7 +958,7 @@ class TestPurjare:
conn.close()
def test_purge_expired_nu_sterge_queued(self, env):
"""T16: purge_expired NU sterge non-sent (queued/error) chiar daca purge_after < now."""
"""purge_expired NU sterge non-sent (queued/error) chiar daca purge_after < now."""
from app.worker.__main__ import purge_expired
client, get_connection, get_settings = env
@@ -981,7 +981,7 @@ class TestPurjare:
conn.close()
def test_purge_after_setat_la_commit_import(self, env):
"""T16: submissions create la commit import au purge_after setat (!=NULL)."""
"""submissions create la commit import au purge_after setat (!=NULL)."""
client, get_connection, get_settings = env
import_id = _upload_and_map(client, rows=[_HEADER, _ROW_1])
@@ -1005,7 +1005,7 @@ class TestPurjare:
conn.close()
def test_purge_after_setat_la_trimitere_worker(self, env):
"""T16: dupa trimitere (status='sent'), purge_after se (re)seteaza la now+90 zile."""
"""dupa trimitere (status='sent'), purge_after se (re)seteaza la now+90 zile."""
import app.worker.__main__ as w
client, get_connection, get_settings = env