feat(web): uniformizare/standardizare UI/UX + lifecycle conturi (PRD 5.5)

Aduce toate suprafetele dashboard-ului la grila tabelului Trimiteri, muta navigarea intr-un meniu de cont (hamburger) si da panoului admin actiuni reale de ciclu de viata. 9 stories, 3 valuri. UI pur (reskin + reasezare) cu O SINGURA exceptie backend: modelul de stare a contului. - US-001 sectiunea "Ajutor" eliminata din Acasa (wayfinding redundant). - US-002 Nomenclator la grila standard (_submissions.html ca referinta). - US-003 macro autosend compact (Manual<->Auto). Semantica de PREZENTA `auto_send` (bifat->true, absent->false) NEALTERATA — compatibil cu ambele parsere (Form(bool) la /mapari, bool(form.get()) la import). Zero backend. - US-004 accounts.status (pending/active/blocked/archived/deleted), migrare defensiva idempotenta derivata din `active`, gate worker claim_one pe status='active' (echivalenta active=1 <=> status='active' pastrata). - US-005 tabel Mapari compact + panou Ajutor (<details>, proza o singura data), coloana "In coada". - US-006 meniu hamburger dropdown (Cont/Integrare/Nomenclator/Admin/logout) + context is_authenticated/is_admin/csrf_token defensiv in base.html. - US-007 tab-bar redus la Acasa+Mapari; rutele /_fragments/{cont,integrare, nomenclator} + deep-link ?tab= raman valide. - US-008 rute admin block/archive/delete + bulk pe lista account_id, require_admin + CSRF + PRG, dev id=1 sarit in bulk. - US-009 admin UI: selectie bife + master + bara bulk + kebab per-rand, grupare pe stare (bloc nou blocate/arhivate), nota "cont dev implicit" scoasa. Stergere = SOFT: tombstone (status='deleted'), dar PII purjata IMEDIAT (rar_creds_enc + chei API revocate + CUI eliberat pentru re-inregistrare), GDPR/L.142. VERIFY: 671 teste pass (+40). E2E browser (Playwright) a prins 2 bug-uri invizibile la TestClient: bara bulk cu display:flex inline invingea [hidden] (mutat in CSS .bulk-bar[hidden]); conturi arhivate cadeau sub "in asteptare" (grupare pe status). /code-review high a prins 2 bug-uri reale: soft delete pastra creds RAR + CUI la nesfarsit fara purjare accounts (GDPR neonorat); apostrof in numele firmei rupea confirm() inline din kebab — ambele reparate, plus cleanup boilerplate rute (_lifecycle_route). Backend trimitere (worker masina stari/idempotenta/mapping) neatins, cu exceptia gate-ului de cont. Design: docs/design/5.5-uniformizare-ui.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 11:56:05 +00:00
parent 14e1c463f0
commit 1fbd894329
27 changed files with 1700 additions and 201 deletions
--- a/tests/test_web_uniformizare.py
+++ b/tests/test_web_uniformizare.py
@@ -0,0 +1,171 @@
+"""Teste PRD 5.5 — uniformizare UI: US-001 (Acasa fara Ajutor), US-002 (Nomenclator grila
+standard), US-003 (macro autosend compact). Stories de template/macro -> render direct Jinja
+pentru US-002/003; US-001 prin TestClient pe fragmentul Acasa.
+"""
+
+from __future__ import annotations
+
+import os
+import re
+import tempfile
+from pathlib import Path
+
+import pytest
+from jinja2 import Environment, FileSystemLoader
+from starlette.testclient import TestClient
+
+_TEMPLATES = Path(__file__).resolve().parents[1] / "app" / "web" / "templates"
+
+
+def _env():
+    return Environment(loader=FileSystemLoader(str(_TEMPLATES)), autoescape=True)
+
+
+# ============================================================
+# US-002: Nomenclator ca tabel standard (grila Trimiteri)
+# ============================================================
+
+def test_nomenclator_grila_standard_cu_randuri():
+    tmpl = _env().get_template("_nomenclator.html")
+    html = tmpl.render(rows=[
+        {"cod_prestatie": "A012", "nume_prestatie": "Revizie tehnica", "updated_at": "2026-06-20"},
+    ])
+    assert "tablewrap" in html
+    assert "<table" in html
+    assert 'class="pill"' in html  # codul in pill, ca la Trimiteri
+    assert "A012" in html and "Revizie tehnica" in html
+
+
+def test_nomenclator_empty_state():
+    tmpl = _env().get_template("_nomenclator.html")
+    html = tmpl.render(rows=[])
+    assert 'class="empty"' in html
+    assert "Nomenclator gol" in html
+
+
+# ============================================================
+# US-003: macro autosend_toggle compact (Auto/Manual)
+# ============================================================
+
+def _render_macro(form_id="map-1", checked=True):
+    mod = _env().get_template("_macros.html").module
+    return str(mod.autosend_toggle(form_id=form_id, checked=checked))
+
+
+def test_autosend_pastreaza_name_si_prezenta():
+    """Invariant backend: checkbox name=auto_send value=true (semantica de prezenta)."""
+    html = _render_macro(checked=True)
+    assert 'type="checkbox"' in html
+    assert 'name="auto_send"' in html
+    assert 'value="true"' in html
+    assert 'form="map-1"' in html
+    assert "checked" in html
+
+
+def test_autosend_nebifat_fara_checked():
+    html = _render_macro(checked=False)
+    assert 'name="auto_send"' in html
+    assert "checked" not in html
+
+
+def test_autosend_compact_fara_proza_inline():
+    """Proza explicativa de pe randuri (3.6) eliminata din CONTINUTUL vizibil — traieste in
+    panoul Ajutor (US-005). Tooltip-ul scurt (atribut title=) e acceptat, deci il scoatem
+    inainte de verificare."""
+    html = _render_macro()
+    vizibil = re.sub(r'title="[^"]*"', "", html)  # scoate atributul title (tooltip)
+    assert "La fisierele viitoare" not in vizibil
+    assert "Tine pentru verificare" not in vizibil
+    assert "nimic nu pleaca la RAR" not in vizibil
+    # ambele etichete de stare vizibile, compact
+    assert "Auto" in html and "Manual" in html
+
+
+# ============================================================
+# US-001: Acasa fara sectiunea Ajutor
+# ============================================================
+
+@pytest.fixture()
+def client(monkeypatch):
+    tmp = tempfile.mkdtemp()
+    monkeypatch.setenv("AUTOPASS_DB_PATH", os.path.join(tmp, "uniform_test.db"))
+    monkeypatch.setenv("AUTOPASS_WEB_AUTH_REQUIRED", "true")
+    from app.config import get_settings
+    get_settings.cache_clear()
+    from app.web import ratelimit
+    ratelimit._hits.clear()
+    from app.main import app
+    with TestClient(app, follow_redirects=False) as c:
+        yield c
+    ratelimit._hits.clear()
+    get_settings.cache_clear()
+
+
+def _login(client, email="u@test.com", password="parolasecreta10"):
+    from app.accounts import create_account
+    from app.users import create_user
+    from app.db import get_connection
+    conn = get_connection()
+    try:
+        acct_id = create_account(conn, "Service Test", active=True)
+        create_user(conn, acct_id, email, password)
+    finally:
+        conn.close()
+    resp = client.get("/login")
+    csrf = re.search(r'name="csrf_token"\s+value="([^"]+)"', resp.text).group(1)
+    resp = client.post("/login", data={"email": email, "parola": password, "csrf_token": csrf})
+    assert resp.status_code == 303
+    return acct_id
+
+
+def test_acasa_fara_sectiune_ajutor(client):
+    _login(client)
+    resp = client.get("/_fragments/acasa")
+    assert resp.status_code == 200
+    # randul "Ajutor:" cu wayfinding Mapari/Coduri RAR eliminat din Acasa
+    assert "Ajutor:" not in resp.text
+    assert "Coduri RAR" not in resp.text
+
+
+# ============================================================
+# US-005: Tabel Mapari standardizat + panou Ajutor
+# ============================================================
+
+def _seed_needs_mapping(acct_id, cod_op="OP-NM", denumire="Operatie test"):
+    import json
+    from app.db import get_connection
+    conn = get_connection()
+    try:
+        conn.execute(
+            "INSERT INTO submissions (idempotency_key, account_id, status, payload_json) "
+            "VALUES (?, ?, 'needs_mapping', ?)",
+            (f"k-{cod_op}", acct_id,
+             json.dumps({"prestatii": [{"cod_op_service": cod_op, "denumire": denumire}]})),
+        )
+        conn.commit()
+    finally:
+        conn.close()
+
+
+def test_mapari_ajutor_disclosure_si_fara_proza_inline(client):
+    acct = _login(client)
+    _seed_needs_mapping(acct)
+    resp = client.get("/_fragments/mapari")
+    assert resp.status_code == 200
+    html = resp.text
+    # panou Ajutor (<details>) prezent
+    assert "ajutor-mapari" in html
+    assert "<details" in html and ">Ajutor<" in html
+    # antet de coloana compact
+    assert ">In coada<" in html
+    # proza inline veche eliminata de pe sectiuni
+    assert "sugestia fuzzy e preselectata) si salveaza" not in html
+    assert "Maparile operatie -> cod RAR retinute pentru contul tau" not in html
+
+
+def test_mapari_comutator_compact_in_tabel(client):
+    acct = _login(client)
+    _seed_needs_mapping(acct)
+    html = client.get("/_fragments/mapari").text
+    assert 'name="auto_send"' in html
+    assert "Manual" in html and "Auto" in html