feat(5.9): US-004 - detaliu editabil in-place + butoane consolidate in modal
- _trimitere_detaliu.html rescris pe ordinea verticala R10: header+motiv, eroare blocanta, mapare inline, formular editabil/context read-only, actiuni, <details> Detalii tehnice colapsat - zero dublare: campurile editabile apar O SINGURA DATA (nr rand propriu, VIN dedesubt, restul in grila); blocul read-only de grila contopit cu formularul - R9: operatie+cod read-only deasupra campurilor cu prez.cod_rar (fallback nemapat), fara eticheta separata Cod RAR - R2 (fix F7): buton primar conditionat de stare - error->Re-pune(/repune), needs_data/needs_mapping->Salveaza si retrimite(/corecteaza); duplicatul gol eliminat - R11: un singur Sterge outline var(--err) pe rand separat, hx-confirm specific, full-width pe mobil (.detaliu-actiuni-jos in @media 767px, base.html) - R5: hx-disabled-elt pe toate formele; inchidere pe succes prin inchideModal - R4: script modal-appropriate pastrat (curatat de US-003) - 6 teste noi in test_web_corectie.py; rutele + _detaliu_ctx NESCHIMBATE - suita 835 passed (-m 'not live'); prd.json/progress.txt US-004 passes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -203,3 +203,100 @@ def test_corectie_cont_strain(client):
|
||||
})
|
||||
assert resp.status_code == 404
|
||||
assert _row(sid1)["status"] == "needs_data" # neatins
|
||||
|
||||
|
||||
# =========================================================================== #
|
||||
# US-004 (PRD 5.9): detaliu editabil in-place, zero dublare, butoane consolidate #
|
||||
# =========================================================================== #
|
||||
|
||||
def _fragment(client, sid: int) -> str:
|
||||
resp = client.get(f"/_fragments/trimitere/{sid}")
|
||||
assert resp.status_code == 200
|
||||
return resp.text
|
||||
|
||||
|
||||
def test_camp_apare_o_singura_data(client):
|
||||
"""Zero dublare: fiecare camp editabil apare exact O DATA (input editabil pre-completat),
|
||||
fara blocul read-only de grila duplicat deasupra formularului."""
|
||||
acct = _create_account_user("u1@test.com")
|
||||
sid = _insert(acct, status="needs_data", payload=_payload("WVWZZZ1JZXW0U1001", odo=""))
|
||||
_login(client, "u1@test.com")
|
||||
html = _fragment(client, sid)
|
||||
|
||||
# Fiecare camp editabil apare exact o data, ca input cu name="...".
|
||||
for camp in ("nr_inmatriculare", "vin", "data_prestatie", "odometru_final", "odometru_initial"):
|
||||
assert html.count(f'name="{camp}"') == 1, f"{camp} trebuie sa apara o singura data"
|
||||
# Nu mai exista eticheta separata „Cod RAR".
|
||||
assert "Cod RAR" not in html
|
||||
|
||||
|
||||
def test_nr_si_vin_pe_randuri_separate(client):
|
||||
"""Nr. inmatriculare pe rand propriu, VIN dedesubt — ambele inputuri latime plina,
|
||||
nr. inaintea VIN-ului in markup."""
|
||||
acct = _create_account_user("u2@test.com")
|
||||
sid = _insert(acct, status="needs_data", payload=_payload("WVWZZZ1JZXW0U2001", odo=""))
|
||||
_login(client, "u2@test.com")
|
||||
html = _fragment(client, sid)
|
||||
|
||||
poz_nr = html.find('name="nr_inmatriculare"')
|
||||
poz_vin = html.find('name="vin"')
|
||||
assert poz_nr != -1 and poz_vin != -1
|
||||
assert poz_nr < poz_vin # nr. apare inaintea VIN-ului (rand propriu, VIN dedesubt)
|
||||
|
||||
|
||||
def test_un_singur_buton_primar_per_stare(client):
|
||||
"""R2: needs_data are UN SINGUR buton primar „Salveaza si retrimite" -> /corecteaza."""
|
||||
acct = _create_account_user("u3@test.com")
|
||||
sid = _insert(acct, status="needs_data", payload=_payload("WVWZZZ1JZXW0U3001", odo=""))
|
||||
_login(client, "u3@test.com")
|
||||
html = _fragment(client, sid)
|
||||
|
||||
assert "Salveaza si retrimite" in html
|
||||
assert html.count("Salveaza si retrimite") == 1
|
||||
assert f"/trimitere/{sid}/corecteaza" in html
|
||||
# needs_data NU ofera butonul de re-pune separat (acela e doar pentru error).
|
||||
assert "Re-pune in coada" not in html
|
||||
|
||||
|
||||
def test_error_foloseste_repune(client):
|
||||
"""R2 (fix F7): un rand `error` NU are formular de corectie; primarul „Re-pune in coada"
|
||||
posteaza pe /repune (NU /corecteaza, care ar da 403)."""
|
||||
acct = _create_account_user("u4@test.com")
|
||||
sid = _insert(acct, status="error", payload=_payload("WVWZZZ1JZXW0U4001"))
|
||||
_login(client, "u4@test.com")
|
||||
html = _fragment(client, sid)
|
||||
|
||||
assert "Re-pune in coada" in html
|
||||
assert f"/trimitere/{sid}/repune" in html
|
||||
# error nu e editabil -> fara post pe /corecteaza si fara butonul de salvare.
|
||||
assert f"/trimitere/{sid}/corecteaza" not in html
|
||||
assert "Salveaza si retrimite" not in html
|
||||
|
||||
|
||||
def test_sterge_prezent_si_distinct(client):
|
||||
"""R11: UN SINGUR Sterge, outline distructiv (var(--err)), pe rand separat, cu hx-confirm
|
||||
specific; posteaza pe /sterge."""
|
||||
acct = _create_account_user("u5@test.com")
|
||||
sid = _insert(acct, status="needs_data", payload=_payload("WVWZZZ1JZXW0U5001", odo=""))
|
||||
_login(client, "u5@test.com")
|
||||
html = _fragment(client, sid)
|
||||
|
||||
assert f"/trimitere/{sid}/sterge" in html
|
||||
assert html.count(f"/trimitere/{sid}/sterge") == 1
|
||||
assert "var(--err)" in html # outline distructiv rosu
|
||||
assert f"Stergi definitiv trimiterea #{sid}? Nu se poate anula." in html
|
||||
|
||||
|
||||
def test_corectie_pastreaza_comportament(client):
|
||||
"""Regresie: retry pur (post pe /corecteaza fara modificari) pe needs_data valid ramane
|
||||
idempotent — randul ajunge queued, ca azi (comportament ruta neschimbat)."""
|
||||
acct = _create_account_user("u6@test.com")
|
||||
# needs_data complet valid (toate campurile prezente) -> retry pur il trece in queued.
|
||||
sid = _insert(acct, status="needs_data", payload=_payload("WVWZZZ1JZXW0U6001", odo="55000"))
|
||||
_login(client, "u6@test.com")
|
||||
csrf = _csrf(client)
|
||||
|
||||
resp = client.post(f"/trimitere/{sid}/corecteaza", data={"csrf_token": csrf})
|
||||
assert resp.status_code == 200
|
||||
assert _row(sid)["status"] == "queued"
|
||||
assert resp.headers.get("HX-Trigger-After-Settle") == "trimiteriChanged, inchideModal"
|
||||
|
||||
Reference in New Issue
Block a user