feat(5.18): VERIFY+CLOSE — US-007 badge sursa + fix findings code-review

VERIFY PASS pe corpus k-NN exemple etichetate (seed real 17181 Haiku, comis
in 756f777): suita 1392 passed, 1 deselected (live); smoke init_db seeder
(17181/NUL=2200/idempotent); toate codurile in nomenclator.

US-007 (cerere user la CLOSE) — badge sursa pe sugestia fuzzy din editor:
- _mapari.html: chip confirmat (GOLD) / similar (SILVER+k-NN) / non-operatie (NUL)
- base.html: .sugg-sursa--{confirmat,similar,nul} pe tokeni de tema (color-mix)
- routes.py: cheia `nul` adaugata in surse_sugestie default (finding cross-file)
- tests/test_web_badge_sursa.py: gold/silver/nul/fara-sursa (4 teste)
- E2E render live verificat in serverul real (/_fragments/mapari)

CLOSE /code-review high (main..HEAD, 3 finder x 8 unghiuri) — runtime curat,
invariant #13 intact; 3 findings low/cosmetic REPARATE + lock-uite:
- shared_store.seed_suggestions: cod whitespace -> NULL (era ''), + test lock
- genereaza_seed.py: with open(...) in loc de open().read() (FD leak tool offline)
- embeddings.py: docstring-uri aliniate la [{cod, is_nul, similaritate}]

ROADMAP: 5.18 LIVRAT. PRD: raport VERIFY/CLOSE scris.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

app/embeddings.py

@@ -11,7 +11,7 @@ Design (PRD 5.14, Decision #16/#16b):
 
 API public (nivel modul):
     index_corpus(items)           -> None
-    suggest_nearest(text, top_k)  -> [{cod, similaritate}]
+    suggest_nearest(text, top_k)  -> [{cod, is_nul, similaritate}]
     is_available()                -> bool
 
 Clase (pentru teste / injectare backend):
@@ -242,7 +242,7 @@ def index_corpus(items: list[dict], signature: str | None = None) -> None:
 
 
 def suggest_nearest(denumire: str, top_k: int = 3) -> list[dict]:
-    """Returneaza top_k sugestii [{cod, similaritate}] sau [] la eroare.
+    """Returneaza top_k sugestii [{cod, is_nul, similaritate}] sau [] la eroare.
 
     Sigur de apelat indiferent de starea backend-ului.
     """

app/shared_store.py

@@ -46,9 +46,12 @@ def seed_suggestions(
             continue
         is_nul = 1 if item.get("is_nul") else 0
         # NUL -> cod NULL obligatoriu (supresie stricta, #4)
-        cod = None if is_nul else ((item.get("cod_prestatie") or "") or None)
-        if cod:
-            cod = cod.strip().upper()
+        # Normalizeaza INAINTE de truthiness: un cod whitespace-only ("   ") sau
+        # ne-string trebuie sa devina NULL, nu '' (altfel rand non-NUL cu cod gol).
+        cod = None
+        if not is_nul:
+            raw_cod = str(item.get("cod_prestatie") or "").strip().upper()
+            cod = raw_cod or None
         source = str(item.get("source") or "llm")
         confidence = float(item.get("confidence") or 0.0)
         cur = conn.execute(

app/web/routes.py

@@ -1247,7 +1247,7 @@ def _nemapate_pentru_submission(row, nomenclator: list[dict], conn=None) -> list
             "denumire": item.get("denumire"),
             "suggestions": suggest_codes(item.get("denumire"), nomenclator, limit=5),
             "sugestie_principala": None,
-            "surse_sugestie": {"gold_partajat": None, "silver": None, "embedding": None},
+            "surse_sugestie": {"gold_partajat": None, "silver": None, "embedding": None, "nul": False},
         }
         # L14-S6: imbogatire cu GOLD partajat > SILVER > embeddings (SUGGESTION-ONLY, #13)
         if conn is not None:

app/web/templates/_mapari.html

@@ -54,11 +54,22 @@
             <div class="muted">{{ e.denumire or '(fara denumire)' }}</div>
           </td>
           <td class="muted" style="font-size:12px;" data-eticheta="Sugestii">
+            {# 5.18 US-007: badge sursa pe sugestia sistemului — confirmat (GOLD) / similar
+               (SILVER+embedding k-NN) / non-operatie (pre-filtru NUL). Suggestion-only. #}
+            {% if e.sugestie_principala %}
+              {% if e.sugestie_principala.sursa == 'gold_partajat' %}
+                <span class="sugg-sursa sugg-sursa--confirmat" title="cod confirmat de un operator">confirmat</span>
+              {% else %}
+                <span class="sugg-sursa sugg-sursa--similar" title="operatie similara deja vazuta (k-NN/exact)">similar</span>
+              {% endif %}
+            {% elif e.surse_sugestie and e.surse_sugestie.nul %}
+              <span class="sugg-sursa sugg-sursa--nul" title="pare non-operatie (ITP/plata/discount...)">non-operatie</span>
+            {% endif %}
             {% if e.suggestions %}
               {% for s in e.suggestions[:3] %}
                 <span class="sugg">{{ s.cod_prestatie }} ({{ s.score|round|int }}%)</span>{% if not loop.last %}, {% endif %}
               {% endfor %}
-            {% else %}—{% endif %}
+            {% elif not e.sugestie_principala and not (e.surse_sugestie and e.surse_sugestie.nul) %}—{% endif %}
           </td>
           <td data-eticheta="Cod RAR">
             <select name="cod_prestatie" form="map-rez-{{ loop.index }}" required

app/web/templates/base.html

@@ -104,6 +104,18 @@
     th { color:var(--muted); font-weight:500; font-size:12px; text-transform:uppercase; letter-spacing:.04em; }
     .empty { color:var(--muted); padding:24px; text-align:center; }
     .pill { font-size:12px; padding:2px 8px; border-radius:99px; border:1px solid var(--line); }
+    /* Badge sursa sugestie (5.18 US-007): de unde vine sugestia de cod in editorul de mapare.
+       confirmat = GOLD validat de om (verde); similar = SILVER/embedding k-NN (azur);
+       non-operatie = pre-filtru NUL / vecin NUL (gri-cald). Suggestion-only, doar indiciu vizual. */
+    .sugg-sursa { display:inline-block; font-size:10px; font-weight:700; line-height:1; padding:2px 6px;
+                  border-radius:99px; text-transform:uppercase; letter-spacing:.03em; vertical-align:middle;
+                  border:1px solid transparent; }
+    .sugg-sursa--confirmat { color:var(--ok); border-color:color-mix(in srgb, var(--ok) 45%, transparent);
+                             background:color-mix(in srgb, var(--ok) 12%, transparent); }
+    .sugg-sursa--similar { color:var(--accent); border-color:color-mix(in srgb, var(--accent) 45%, transparent);
+                           background:color-mix(in srgb, var(--accent) 12%, transparent); }
+    .sugg-sursa--nul { color:var(--muted); border-color:color-mix(in srgb, var(--muted) 40%, transparent);
+                       background:color-mix(in srgb, var(--muted) 12%, transparent); }
     /* Pill-uri de filtrare a starii (bara de filtre Trimiteri). Inactiv = contur+text pe
        culoarea categoriei (injectata inline); activ = umplere pe acea culoare. */
     .pills-categorii { display:inline-flex; gap:8px; flex-wrap:wrap; align-items:center; }