Files
gomag-vending/api
Claude Agent bcd65d9fd6 fix(retry): pre-populate price list before re-importing failed orders
Production VENDING orders #485841978 and #485841895 (2026-04-28) crashed
on Retry with PL/SQL COM-001 because the retry path skipped the
CRM_POLITICI_PRET_ART pre-population step that bulk sync runs.

The price-list auto-insert (PRET=0) for missing CODMATs was only invoked
in sync_service.run_sync (lines 592-718). retry_service called
import_single_order directly, hitting pack_comenzi.adauga_articol_comanda
NO_DATA_FOUND on every CODMAT without a price entry.

Extracted the validation block into validation_service.pre_validate_order_prices
and call it from both bulk sync and retry. Single source of truth for
SKU validation, dual-policy routing (cont 341/345 → productie),
ARTICOLE_TERTI mapping resolution, and kit component price gating.

Tests: 3 unit + 3 oracle integration covering the regression scenario,
empty input, dual-policy routing, idempotency, and pre-validation
exception propagation.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-29 10:19:38 +00:00
..

GoMag Import Manager - FastAPI Application

Admin interface si orchestrator pentru importul comenzilor GoMag in Oracle ROA.

Componente

Core

  • main.py - Entry point FastAPI, lifespan (Oracle pool + SQLite init), file logging
  • config.py - Settings via pydantic-settings (citeste .env)
  • database.py - Oracle connection pool + SQLite schema + helpers

Routers (HTTP Endpoints)

Router Prefix Descriere
health /health, /api/health Status Oracle + SQLite
dashboard / Dashboard HTML cu stat cards
mappings /mappings, /api/mappings CRUD ARTICOLE_TERTI + CSV
articles /api/articles Cautare NOM_ARTICOLE
validation /api/validate Scanare + validare SKU-uri
sync /sync, /api/sync Import orchestration + scheduler

Services (Business Logic)

Service Rol
mapping_service CRUD pe ARTICOLE_TERTI (Oracle)
article_service Cautare in NOM_ARTICOLE (Oracle)
import_service Port din VFP: partner/address/order creation
sync_service Orchestrare: read JSONs → validate → import → log
price_sync_service Sync preturi GoMag → Oracle politici de pret
invoice_service Verificare facturi ROA + cache SQLite
validation_service Batch-validare SKU-uri (chunks of 500)
order_reader Citire gomag_orders_page*.json din vfp/output/
sqlite_service CRUD pe SQLite (sync_runs, import_orders, missing_skus)
scheduler_service APScheduler - sync periodic configurabil din UI

Rulare

pip install -r requirements.txt
# INTOTDEAUNA via start.sh din project root (seteaza Oracle env vars)
cd .. && ./start.sh

Testare

# Din project root:
./test.sh ci       # Teste rapide (unit + e2e, ~30s, fara Oracle)
./test.sh full     # Teste complete (inclusiv Oracle, ~2-3 min)
./test.sh unit     # Doar unit tests
./test.sh e2e      # Doar browser tests (Playwright)
./test.sh oracle   # Doar Oracle integration

Dual Database

  • Oracle - date ERP (ARTICOLE_TERTI, NOM_ARTICOLE, COMENZI)
  • SQLite - tracking local (sync_runs, import_orders, missing_skus, scheduler_config)

Logging

Log files in ../logs/sync_comenzi_YYYYMMDD_HHMMSS.log Format: 2026-03-11 14:30:25 | INFO | app.services.sync_service | mesaj