romfast/gomag-vending
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(price): remove baseprice detection, use directional price match

Browse Source 
baseprice > price was wrongly treated as "quantity discount" — it's just
GoMag's promotional price. Now: price_gomag <= pret_roa is always OK,
only flag when GoMag charges MORE than ROA. Reset cached price_match
at startup for re-evaluation. Fix dashboard dot color for mismatches.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Claude Agent
2026-04-07 20:41:54 +00:00
parent b28f9d7611
commit bf194eb088
8 changed files with 26 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
api/app/services/validation_service.py
View File

@@ -714,13 +714,6 @@ def get_prices_for_order(items: list[dict], app_settings: dict, conn=None) -> di
result_items[idx]["kit"] = True
continue
# Quantity discount: baseprice > price means GoMag applied a volume discount
baseprice = float(item.get("baseprice") or 0)
if baseprice > 0 and baseprice > pret_gomag + 0.01:
result_items[idx]["quantity_discount"] = True
result_items[idx]["baseprice"] = baseprice
continue
pret_roa_total = 0.0
all_resolved = True
@@ -766,7 +759,7 @@ def get_prices_for_order(items: list[dict], app_settings: dict, conn=None) -> di
continue
pret_roa = round(pret_roa_total, 4)
match = abs(pret_gomag - pret_roa) < 0.01
match = pret_gomag <= pret_roa + 0.01
result_items[idx]["pret_roa"] = pret_roa
result_items[idx]["match"] = match
checked += 1