romfast/gomag-vending
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(address): use SOUNDEX city matching and strip SECTORUL from city

Browse Source 
Fixes false negatives where city spellings differ slightly (e.g.
"Sfântu Ilie" vs "SFINTU ILIE") or ROA stores "BUCURESTI SECTORUL 1"
while GoMag sends "Municipiul București". Both backend (_addr_match)
and frontend (addrMatch) now use identical SOUNDEX logic mirroring
Oracle's implementation.

Also fixes field order: etaj before apart in r_street concatenation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Claude Agent
2026-04-08 22:31:36 +00:00
parent f48c2d62c6
commit 5eba87976b
4 changed files with 64 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
api/app/static/js/shared.js
View File

@@ -830,16 +830,33 @@ function addrMatch(gomag, roa) {
function norm(s) {
return (s || '').replace(/[\u0103\u00e2\u00ee\u0219\u021b\u0102\u00c2\u00ce\u0218\u021a\u015f\u0163\u015e\u0162]/g, c => _DIAC[c] || c)
.toUpperCase()
.replace(/\bSECTORUL\s*\d*/g, '')
.replace(/\b(STR|STRADA|NR|NUMAR|NUMARUL|BL|BLOC|SC|SCARA|AP|APART|APARTAMENT|ET|ETAJ|COM|COMUNA|SAT|MUN|MUNICIPIUL|JUD|JUDETUL|CARTIER|PARTER|SECTOR|SECTORUL|ORAS)(?:\b|(?=\d))/g, '')
.replace(/[^A-Z0-9]/g, '');
}
function soundex(s) {
if (!s) return '';
const code = {B:1,F:1,P:1,V:1,C:2,G:2,J:2,K:2,Q:2,S:2,X:2,Z:2,
D:3,T:3,L:4,M:5,N:5,R:6};
let result = s[0], prev = code[s[0]] || 0;
for (let i = 1; i < s.length && result.length < 4; i++) {
const c = s[i];
if ('AEIOU'.includes(c)) { prev = 0; }
else if (c !== 'H' && c !== 'W') {
const d = code[c];
if (d && d !== prev) result += d;
if (d) prev = d;
}
}
return result.padEnd(4, '0');
}
const gStreet = norm(gomag.address || gomag.strada || '');
const rStreet = norm((roa.strada||'') + (roa.numar||'') + (roa.bloc||'') + (roa.scara||'') + (roa.apart||'') + (roa.etaj||''));
const rStreet = norm((roa.strada||'') + (roa.numar||'') + (roa.bloc||'') + (roa.scara||'') + (roa.etaj||'') + (roa.apart||''));
const gCity = norm(gomag.city || gomag.localitate || '');
const rCity = norm(roa.localitate || '');
const gRegion = norm(gomag.region || gomag.judet || '');
const rRegion = norm(roa.judet || '');
return gStreet === rStreet && gCity === rCity && gRegion === rRegion;
return gStreet === rStreet && soundex(gCity) === soundex(rCity) && gRegion === rRegion;
}
function hasEfacturaRisk(roa) {