fix(mappings): move sku/codmat from path to query — slash in keys 404'd
Codurile ROA contin legitim '/' si '"' (ex. RCR1/4"). Rutele FastAPI
foloseau parametri de cale (/api/mappings/{sku}/{codmat}...); ASGI decodeaza
%2F -> '/' INAINTE de routing, deci o cheie cu slash devine doua segmente si
Starlette nu mai potriveste ruta -> 404 la edit/delete/restore. Cand ambii
parametri au slash, un convertor {path} nu rezolva (split ambiguu).
Solutie: sku/codmat trec din cale in query string. %2F/%22 din query se
decodeaza ca parte a valorii, fara sa atinga routing-ul de cale.
- backend: 4 rute statice + Query(...) (update/edit/delete/restore);
semnaturile mapping_service raman neschimbate
- frontend: helper mapQS(); toate cele 8 apeluri path -> query; cache-bust ?v=19
- tests: regresie ci-layer (chei-sentinel cu slash, !=404, toate 4 rutele);
test_integration update/delete convertite la query; e2e delete RCR1/4"
(slash+ghilimea) prin modalul UI, skip cand Oracle lipseste
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -95,16 +95,18 @@ async def create_mapping(data: MappingCreate):
|
||||
except Exception as e:
|
||||
return {"success": False, "error": str(e)}
|
||||
|
||||
@router.put("/api/mappings/{sku}/{codmat}")
|
||||
def update_mapping(sku: str, codmat: str, data: MappingUpdate):
|
||||
# sku/codmat in query string (not path) — codurile ROA contin legitim '/' si '"'
|
||||
# (ex. RCR1/4"); %2F in path e decodat de ASGI inainte de routing -> 404.
|
||||
@router.put("/api/mappings/update")
|
||||
def update_mapping(data: MappingUpdate, sku: str = Query(...), codmat: str = Query(...)):
|
||||
try:
|
||||
updated = mapping_service.update_mapping(sku, codmat, data.cantitate_roa, data.activ)
|
||||
return {"success": updated}
|
||||
except Exception as e:
|
||||
return {"success": False, "error": str(e)}
|
||||
|
||||
@router.put("/api/mappings/{sku}/{codmat}/edit")
|
||||
def edit_mapping(sku: str, codmat: str, data: MappingEdit):
|
||||
@router.put("/api/mappings/edit")
|
||||
def edit_mapping(data: MappingEdit, sku: str = Query(...), codmat: str = Query(...)):
|
||||
try:
|
||||
result = mapping_service.edit_mapping(sku, codmat, data.new_sku, data.new_codmat,
|
||||
data.cantitate_roa)
|
||||
@@ -112,16 +114,16 @@ def edit_mapping(sku: str, codmat: str, data: MappingEdit):
|
||||
except Exception as e:
|
||||
return {"success": False, "error": str(e)}
|
||||
|
||||
@router.delete("/api/mappings/{sku}/{codmat}")
|
||||
def delete_mapping(sku: str, codmat: str):
|
||||
@router.delete("/api/mappings/delete")
|
||||
def delete_mapping(sku: str = Query(...), codmat: str = Query(...)):
|
||||
try:
|
||||
deleted = mapping_service.delete_mapping(sku, codmat)
|
||||
return {"success": deleted}
|
||||
except Exception as e:
|
||||
return {"success": False, "error": str(e)}
|
||||
|
||||
@router.post("/api/mappings/{sku}/{codmat}/restore")
|
||||
def restore_mapping(sku: str, codmat: str):
|
||||
@router.post("/api/mappings/restore")
|
||||
def restore_mapping(sku: str = Query(...), codmat: str = Query(...)):
|
||||
try:
|
||||
restored = mapping_service.restore_mapping(sku, codmat)
|
||||
return {"success": restored}
|
||||
|
||||
Reference in New Issue
Block a user