romfast/gomag-vending
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ui): remove redundant price badge from order detail modal

Browse Source 
Header diff badges already show price mismatches, making the Status-line
badge duplicative.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Claude Agent
2026-04-06 16:11:49 +00:00
parent 86e8d54d5e
commit 51910148ef
2 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
api/app/static/js/shared.js
View File

@@ -513,8 +513,6 @@ async function renderOrderDetailModal(orderNumber, opts) {
if (invInfo) invInfo.style.display = 'none'; if (invInfo) invInfo.style.display = 'none';
const mobileContainer = document.getElementById('detailItemsMobile'); const mobileContainer = document.getElementById('detailItemsMobile');
if (mobileContainer) mobileContainer.innerHTML = ''; if (mobileContainer) mobileContainer.innerHTML = '';
const priceCheckEl = document.getElementById('detailPriceCheck');
if (priceCheckEl) priceCheckEl.innerHTML = '';
const reconEl = document.getElementById('detailInvoiceRecon'); const reconEl = document.getElementById('detailInvoiceRecon');
if (reconEl) { reconEl.innerHTML = ''; reconEl.style.display = 'none'; } if (reconEl) { reconEl.innerHTML = ''; reconEl.style.display = 'none'; }
// Remove diff badge from previous render // Remove diff badge from previous render
@@ -557,19 +555,6 @@ async function renderOrderDetailModal(orderNumber, opts) {
document.getElementById('detailDate').textContent = fmtDate(order.order_date); document.getElementById('detailDate').textContent = fmtDate(order.order_date);
document.getElementById('detailStatus').innerHTML = orderStatusBadge(order.status); document.getElementById('detailStatus').innerHTML = orderStatusBadge(order.status);
// Price check badge
const priceCheckEl = document.getElementById('detailPriceCheck');
if (priceCheckEl) {
const pc = order.price_check;
if (!pc || pc.oracle_available === false) {
priceCheckEl.innerHTML = '<span class="badge" style="background:var(--cancelled-light);color:var(--text-muted)">Preturi ROA indisponibile</span>';
} else if (pc.mismatches === 0) {
priceCheckEl.innerHTML = '<span class="badge" style="background:var(--success-light);color:var(--success-text)">✓ Preturi OK</span>';
} else {
priceCheckEl.innerHTML = `<span class="badge" style="background:var(--error-light);color:var(--error-text)">${pc.mismatches} diferente de pret</span>`;
}
}
document.getElementById('detailIdComanda').textContent = order.id_comanda || '-'; document.getElementById('detailIdComanda').textContent = order.id_comanda || '-';
document.getElementById('detailIdPartener').textContent = order.id_partener || '-'; document.getElementById('detailIdPartener').textContent = order.id_partener || '-';

4
api/app/templates/base.html
View File

@@ -101,7 +101,7 @@
<small class="text-muted">CUI:</small> <span class="font-data" id="detailCuiGomagVal"></span> <small class="text-muted">CUI:</small> <span class="font-data" id="detailCuiGomagVal"></span>
</div> </div>
<div><small class="text-muted">Data:</small> <span id="detailDate"></span></div> <div><small class="text-muted">Data:</small> <span id="detailDate"></span></div>
<div><small class="text-muted">Status:</small> <span id="detailStatus"></span><span id="detailPriceCheck" class="ms-2"></span></div> <div><small class="text-muted">Status:</small> <span id="detailStatus"></span></div>
</div> </div>
<!-- ROA Column --> <!-- ROA Column -->
<div class="col-md-6"> <div class="col-md-6">
@@ -161,7 +161,7 @@
<script>window.ROOT_PATH = "{{ rp }}";</script> <script>window.ROOT_PATH = "{{ rp }}";</script>
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.2/dist/js/bootstrap.bundle.min.js"></script> <script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.2/dist/js/bootstrap.bundle.min.js"></script>
<script src="{{ rp }}/static/js/shared.js?v=29"></script> <script src="{{ rp }}/static/js/shared.js?v=30"></script>
<script> <script>
// Dark mode toggle // Dark mode toggle
function toggleDarkMode() { function toggleDarkMode() {