feat(anaf-dedup): ANAF partner dedup + address fix + UI enrichment
Prevent partner duplicates via ANAF CUI verification and dual PL/SQL search. Fix address matching with street-level comparison and diacritics normalization. Show partner/address comparison in order detail modal. - New anaf_service.py: batch ANAF API client with chunking, retry, cache - PL/SQL: dual CUI search (bare/RO+bare/RO space+bare), 3-tier address search (street+city+id_loc → city+id_loc → create), strip_diacritics at storage for addresses and partner names - SQLite: anaf_cache table, 12 new order columns for partner/address data - import_service: cod_fiscal_override param, return partner/address from Oracle - sync_service: ANAF batch integration, denomination mismatch detection, cache pre-population trigger - Router: enriched order_detail with partner_info + addresses JSON - UI: collapsible Detalii Partener + Adrese Comparativ sections in modal, auto-expand on mismatch, ANAF badges, mobile address cards - Dashboard: address quality attention indicator - New scan_duplicate_partners.py script for one-time duplicate audit Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
142
api/app/services/anaf_service.py
Normal file
142
api/app/services/anaf_service.py
Normal file
@@ -0,0 +1,142 @@
|
||||
import re
|
||||
import logging
|
||||
import httpx
|
||||
import asyncio
|
||||
from datetime import datetime
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
# Romanian diacritics to ASCII mapping (same 14 chars as import_service)
|
||||
_DIACRITICS = str.maketrans('ĂăÂâÎîȘșȚțŞşŢţ', 'AAAAIISSTTSSTT')
|
||||
|
||||
|
||||
def strip_ro_prefix(cod_fiscal: str) -> str:
|
||||
"""Normalize CUI: strip whitespace, uppercase, remove 'RO' prefix."""
|
||||
if not cod_fiscal:
|
||||
return ""
|
||||
cleaned = cod_fiscal.strip().upper()
|
||||
return re.sub(r'^RO\s*', '', cleaned)
|
||||
|
||||
|
||||
def validate_cui(bare_cui: str) -> bool:
|
||||
"""Validate bare CUI: digits only, length 1-13."""
|
||||
if not bare_cui:
|
||||
return False
|
||||
return bare_cui.isdigit() and 1 <= len(bare_cui) <= 13
|
||||
|
||||
|
||||
async def check_vat_status_batch(cui_list: list[str], date: str = None) -> dict[str, dict]:
|
||||
"""POST to ANAF API to check VAT status for a batch of CUIs.
|
||||
|
||||
Chunks in batches of 500 (ANAF API limit).
|
||||
Returns {cui_str: {"scpTVA": bool|None, "denumire_anaf": str, "checked_at": str}, ...}
|
||||
"""
|
||||
if not cui_list:
|
||||
return {}
|
||||
|
||||
check_date = date or datetime.now().strftime("%Y-%m-%d")
|
||||
results = {}
|
||||
|
||||
for i in range(0, len(cui_list), 500):
|
||||
chunk = cui_list[i:i+500]
|
||||
body = [{"cui": int(cui), "data": check_date} for cui in chunk if cui.isdigit()]
|
||||
if not body:
|
||||
continue
|
||||
|
||||
chunk_results = await _call_anaf_api(body)
|
||||
results.update(chunk_results)
|
||||
|
||||
return results
|
||||
|
||||
|
||||
async def _call_anaf_api(body: list[dict], retry: int = 0) -> dict[str, dict]:
|
||||
"""Internal: single ANAF API call with retry logic."""
|
||||
url = "https://webservicesp.anaf.ro/api/PlatitorTvaRest/v9/tva"
|
||||
results = {}
|
||||
|
||||
try:
|
||||
async with httpx.AsyncClient(timeout=10.0) as client:
|
||||
response = await client.post(url, json=body)
|
||||
|
||||
if response.status_code == 429:
|
||||
if retry < 1:
|
||||
logger.warning("ANAF API rate limited (429), retrying in 10s...")
|
||||
await asyncio.sleep(10)
|
||||
return await _call_anaf_api(body, retry + 1)
|
||||
logger.error("ANAF API rate limited after retry")
|
||||
return {}
|
||||
|
||||
if response.status_code >= 500:
|
||||
if retry < 1:
|
||||
logger.warning(f"ANAF API server error ({response.status_code}), retrying in 3s...")
|
||||
await asyncio.sleep(3)
|
||||
return await _call_anaf_api(body, retry + 1)
|
||||
logger.error(f"ANAF API server error after retry: {response.status_code}")
|
||||
return {}
|
||||
|
||||
response.raise_for_status()
|
||||
data = response.json()
|
||||
|
||||
checked_at = datetime.now().isoformat()
|
||||
|
||||
# Parse ANAF response
|
||||
found_list = data.get("found", [])
|
||||
for item in found_list:
|
||||
cui_str = str(item.get("cui", ""))
|
||||
date_generals = item.get("date_generale", {})
|
||||
results[cui_str] = {
|
||||
"scpTVA": item.get("inregistrare_scop_Tva", {}).get("scpTVA"),
|
||||
"denumire_anaf": date_generals.get("denumire", ""),
|
||||
"checked_at": checked_at,
|
||||
}
|
||||
|
||||
# Not found CUIs
|
||||
notfound_list = data.get("notfound", [])
|
||||
for item in notfound_list:
|
||||
cui_str = str(item.get("cui", ""))
|
||||
results[cui_str] = {
|
||||
"scpTVA": None,
|
||||
"denumire_anaf": "",
|
||||
"checked_at": checked_at,
|
||||
}
|
||||
|
||||
logger.info(f"ANAF batch: {len(body)} CUIs → {len(found_list)} found, {len(notfound_list)} not found")
|
||||
|
||||
except httpx.TimeoutException:
|
||||
if retry < 1:
|
||||
logger.warning("ANAF API timeout, retrying in 3s...")
|
||||
await asyncio.sleep(3)
|
||||
return await _call_anaf_api(body, retry + 1)
|
||||
logger.error("ANAF API timeout after retry")
|
||||
except Exception as e:
|
||||
if retry < 1:
|
||||
logger.warning(f"ANAF API error: {e}, retrying in 3s...")
|
||||
await asyncio.sleep(3)
|
||||
return await _call_anaf_api(body, retry + 1)
|
||||
logger.error(f"ANAF API error after retry: {e}")
|
||||
|
||||
return results
|
||||
|
||||
|
||||
def determine_correct_cod_fiscal(bare_cui: str, is_vat_payer: bool | None) -> str:
|
||||
"""Determine the correct cod_fiscal format based on ANAF VAT status.
|
||||
True → "RO" + bare, False → bare, None → bare (conservative)
|
||||
"""
|
||||
if is_vat_payer is True:
|
||||
return "RO" + bare_cui
|
||||
return bare_cui
|
||||
|
||||
|
||||
def normalize_company_name(name: str) -> str:
|
||||
"""Normalize company name for comparison: strip SRL/SA suffixes, diacritics, punctuation."""
|
||||
if not name:
|
||||
return ""
|
||||
result = name.strip().upper()
|
||||
# Strip diacritics
|
||||
result = result.translate(_DIACRITICS)
|
||||
# Remove common suffixes
|
||||
result = re.sub(r'\b(S\.?R\.?L\.?|S\.?A\.?|S\.?C\.?|S\.?N\.?C\.?|S\.?C\.?S\.?)\b', '', result)
|
||||
# Remove punctuation and extra spaces
|
||||
result = re.sub(r'[^\w\s]', '', result)
|
||||
result = re.sub(r'\s+', ' ', result).strip()
|
||||
return result
|
||||
Reference in New Issue
Block a user