fix: capture all intermediate text blocks from Claude tool-use responses
Switch from --output-format json to --output-format stream-json --verbose so that _run_claude() parses all assistant text blocks (not just the final result field). Discord/Telegram/WhatsApp now receive every intermediate message Claude writes between tool calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -157,7 +157,12 @@ def _save_sessions(data: dict) -> None:
|
|||||||
|
|
||||||
|
|
||||||
def _run_claude(cmd: list[str], timeout: int) -> dict:
|
def _run_claude(cmd: list[str], timeout: int) -> dict:
|
||||||
"""Run a Claude CLI command and return the parsed JSON output."""
|
"""Run a Claude CLI command and return parsed output.
|
||||||
|
|
||||||
|
Expects ``--output-format stream-json --verbose``. Parses the newline-
|
||||||
|
delimited JSON stream, collecting every text block from ``assistant``
|
||||||
|
messages and metadata from the final ``result`` line.
|
||||||
|
"""
|
||||||
if not shutil.which(CLAUDE_BIN):
|
if not shutil.which(CLAUDE_BIN):
|
||||||
raise FileNotFoundError(
|
raise FileNotFoundError(
|
||||||
"Claude CLI not found. "
|
"Claude CLI not found. "
|
||||||
@@ -184,12 +189,50 @@ def _run_claude(cmd: list[str], timeout: int) -> dict:
|
|||||||
f"Claude CLI error (exit {proc.returncode}): {detail}"
|
f"Claude CLI error (exit {proc.returncode}): {detail}"
|
||||||
)
|
)
|
||||||
|
|
||||||
try:
|
# --- Parse stream-json output ---
|
||||||
data = json.loads(proc.stdout)
|
text_blocks: list[str] = []
|
||||||
except json.JSONDecodeError as exc:
|
result_obj: dict | None = None
|
||||||
raise RuntimeError(f"Failed to parse Claude CLI output: {exc}")
|
|
||||||
|
|
||||||
return data
|
for line in proc.stdout.splitlines():
|
||||||
|
line = line.strip()
|
||||||
|
if not line:
|
||||||
|
continue
|
||||||
|
try:
|
||||||
|
obj = json.loads(line)
|
||||||
|
except json.JSONDecodeError:
|
||||||
|
continue
|
||||||
|
|
||||||
|
msg_type = obj.get("type")
|
||||||
|
|
||||||
|
if msg_type == "assistant":
|
||||||
|
# Extract text from content blocks
|
||||||
|
message = obj.get("message", {})
|
||||||
|
for block in message.get("content", []):
|
||||||
|
if block.get("type") == "text":
|
||||||
|
text = block.get("text", "").strip()
|
||||||
|
if text:
|
||||||
|
text_blocks.append(text)
|
||||||
|
|
||||||
|
elif msg_type == "result":
|
||||||
|
result_obj = obj
|
||||||
|
|
||||||
|
if result_obj is None:
|
||||||
|
raise RuntimeError(
|
||||||
|
"Failed to parse Claude CLI output: no result line in stream"
|
||||||
|
)
|
||||||
|
|
||||||
|
# Build a dict compatible with the old json output format
|
||||||
|
combined_text = "\n\n".join(text_blocks) if text_blocks else result_obj.get("result", "")
|
||||||
|
|
||||||
|
return {
|
||||||
|
"result": combined_text,
|
||||||
|
"session_id": result_obj.get("session_id", ""),
|
||||||
|
"usage": result_obj.get("usage", {}),
|
||||||
|
"total_cost_usd": result_obj.get("total_cost_usd", 0),
|
||||||
|
"cost_usd": result_obj.get("cost_usd", 0),
|
||||||
|
"duration_ms": result_obj.get("duration_ms", 0),
|
||||||
|
"num_turns": result_obj.get("num_turns", 0),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
# ---------------------------------------------------------------------------
|
# ---------------------------------------------------------------------------
|
||||||
@@ -248,7 +291,7 @@ def start_session(
|
|||||||
cmd = [
|
cmd = [
|
||||||
CLAUDE_BIN, "-p", wrapped_message,
|
CLAUDE_BIN, "-p", wrapped_message,
|
||||||
"--model", model,
|
"--model", model,
|
||||||
"--output-format", "json",
|
"--output-format", "stream-json", "--verbose",
|
||||||
"--system-prompt", system_prompt,
|
"--system-prompt", system_prompt,
|
||||||
"--allowedTools", *ALLOWED_TOOLS,
|
"--allowedTools", *ALLOWED_TOOLS,
|
||||||
]
|
]
|
||||||
@@ -258,7 +301,7 @@ def start_session(
|
|||||||
_elapsed_ms = int((time.monotonic() - _t0) * 1000)
|
_elapsed_ms = int((time.monotonic() - _t0) * 1000)
|
||||||
|
|
||||||
for field in ("result", "session_id"):
|
for field in ("result", "session_id"):
|
||||||
if field not in data:
|
if not data.get(field):
|
||||||
raise RuntimeError(
|
raise RuntimeError(
|
||||||
f"Claude CLI response missing required field: {field}"
|
f"Claude CLI response missing required field: {field}"
|
||||||
)
|
)
|
||||||
@@ -317,7 +360,7 @@ def resume_session(
|
|||||||
cmd = [
|
cmd = [
|
||||||
CLAUDE_BIN, "-p", wrapped_message,
|
CLAUDE_BIN, "-p", wrapped_message,
|
||||||
"--resume", session_id,
|
"--resume", session_id,
|
||||||
"--output-format", "json",
|
"--output-format", "stream-json", "--verbose",
|
||||||
"--allowedTools", *ALLOWED_TOOLS,
|
"--allowedTools", *ALLOWED_TOOLS,
|
||||||
]
|
]
|
||||||
|
|
||||||
@@ -325,7 +368,7 @@ def resume_session(
|
|||||||
data = _run_claude(cmd, timeout)
|
data = _run_claude(cmd, timeout)
|
||||||
_elapsed_ms = int((time.monotonic() - _t0) * 1000)
|
_elapsed_ms = int((time.monotonic() - _t0) * 1000)
|
||||||
|
|
||||||
if "result" not in data:
|
if not data.get("result"):
|
||||||
raise RuntimeError(
|
raise RuntimeError(
|
||||||
"Claude CLI response missing required field: result"
|
"Claude CLI response missing required field: result"
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -28,21 +28,45 @@ from src.claude_session import (
|
|||||||
# Helpers
|
# Helpers
|
||||||
# ---------------------------------------------------------------------------
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
FAKE_CLI_RESPONSE = {
|
FAKE_RESULT_LINE = {
|
||||||
"type": "result",
|
"type": "result",
|
||||||
"subtype": "success",
|
"subtype": "success",
|
||||||
"session_id": "sess-abc-123",
|
"session_id": "sess-abc-123",
|
||||||
"result": "Hello from Claude!",
|
"result": "Hello from Claude!",
|
||||||
"cost_usd": 0.004,
|
"cost_usd": 0.004,
|
||||||
|
"total_cost_usd": 0.004,
|
||||||
"duration_ms": 1500,
|
"duration_ms": 1500,
|
||||||
"num_turns": 1,
|
"num_turns": 1,
|
||||||
|
"usage": {"input_tokens": 100, "output_tokens": 50},
|
||||||
|
}
|
||||||
|
|
||||||
|
FAKE_ASSISTANT_LINE = {
|
||||||
|
"type": "assistant",
|
||||||
|
"message": {
|
||||||
|
"content": [{"type": "text", "text": "Hello from Claude!"}],
|
||||||
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _make_stream(*assistant_texts, result_override=None):
|
||||||
|
"""Build stream-json stdout with assistant + result lines."""
|
||||||
|
lines = []
|
||||||
|
for text in assistant_texts:
|
||||||
|
lines.append(json.dumps({
|
||||||
|
"type": "assistant",
|
||||||
|
"message": {"content": [{"type": "text", "text": text}]},
|
||||||
|
}))
|
||||||
|
result = dict(FAKE_RESULT_LINE)
|
||||||
|
if result_override:
|
||||||
|
result.update(result_override)
|
||||||
|
lines.append(json.dumps(result))
|
||||||
|
return "\n".join(lines)
|
||||||
|
|
||||||
|
|
||||||
def _make_proc(stdout=None, returncode=0, stderr=""):
|
def _make_proc(stdout=None, returncode=0, stderr=""):
|
||||||
"""Build a fake subprocess.CompletedProcess."""
|
"""Build a fake subprocess.CompletedProcess with stream-json output."""
|
||||||
if stdout is None:
|
if stdout is None:
|
||||||
stdout = json.dumps(FAKE_CLI_RESPONSE)
|
stdout = _make_stream("Hello from Claude!")
|
||||||
proc = MagicMock(spec=subprocess.CompletedProcess)
|
proc = MagicMock(spec=subprocess.CompletedProcess)
|
||||||
proc.stdout = stdout
|
proc.stdout = stdout
|
||||||
proc.stderr = stderr
|
proc.stderr = stderr
|
||||||
@@ -153,10 +177,20 @@ class TestSafeEnv:
|
|||||||
class TestRunClaude:
|
class TestRunClaude:
|
||||||
@patch("shutil.which", return_value="/usr/bin/claude")
|
@patch("shutil.which", return_value="/usr/bin/claude")
|
||||||
@patch("subprocess.run")
|
@patch("subprocess.run")
|
||||||
def test_returns_parsed_json(self, mock_run, mock_which):
|
def test_returns_parsed_stream(self, mock_run, mock_which):
|
||||||
mock_run.return_value = _make_proc()
|
mock_run.return_value = _make_proc()
|
||||||
result = _run_claude(["claude", "-p", "hi"], timeout=30)
|
result = _run_claude(["claude", "-p", "hi"], timeout=30)
|
||||||
assert result == FAKE_CLI_RESPONSE
|
assert result["result"] == "Hello from Claude!"
|
||||||
|
assert result["session_id"] == "sess-abc-123"
|
||||||
|
assert "usage" in result
|
||||||
|
|
||||||
|
@patch("shutil.which", return_value="/usr/bin/claude")
|
||||||
|
@patch("subprocess.run")
|
||||||
|
def test_collects_multiple_text_blocks(self, mock_run, mock_which):
|
||||||
|
stdout = _make_stream("First message", "Second message", "Third message")
|
||||||
|
mock_run.return_value = _make_proc(stdout=stdout)
|
||||||
|
result = _run_claude(["claude", "-p", "hi"], timeout=30)
|
||||||
|
assert result["result"] == "First message\n\nSecond message\n\nThird message"
|
||||||
|
|
||||||
@patch("shutil.which", return_value="/usr/bin/claude")
|
@patch("shutil.which", return_value="/usr/bin/claude")
|
||||||
@patch("subprocess.run")
|
@patch("subprocess.run")
|
||||||
@@ -176,9 +210,11 @@ class TestRunClaude:
|
|||||||
|
|
||||||
@patch("shutil.which", return_value="/usr/bin/claude")
|
@patch("shutil.which", return_value="/usr/bin/claude")
|
||||||
@patch("subprocess.run")
|
@patch("subprocess.run")
|
||||||
def test_invalid_json_raises(self, mock_run, mock_which):
|
def test_no_result_line_raises(self, mock_run, mock_which):
|
||||||
mock_run.return_value = _make_proc(stdout="not json {{{")
|
# Stream with only an assistant line but no result line
|
||||||
with pytest.raises(RuntimeError, match="Failed to parse"):
|
stdout = json.dumps({"type": "assistant", "message": {"content": []}})
|
||||||
|
mock_run.return_value = _make_proc(stdout=stdout)
|
||||||
|
with pytest.raises(RuntimeError, match="no result line"):
|
||||||
_run_claude(["claude", "-p", "hi"], timeout=30)
|
_run_claude(["claude", "-p", "hi"], timeout=30)
|
||||||
|
|
||||||
@patch("shutil.which", return_value=None)
|
@patch("shutil.which", return_value=None)
|
||||||
@@ -299,7 +335,7 @@ class TestStartSession:
|
|||||||
|
|
||||||
@patch("shutil.which", return_value="/usr/bin/claude")
|
@patch("shutil.which", return_value="/usr/bin/claude")
|
||||||
@patch("subprocess.run")
|
@patch("subprocess.run")
|
||||||
def test_missing_result_field_raises(
|
def test_missing_result_line_raises(
|
||||||
self, mock_run, mock_which, tmp_path, monkeypatch
|
self, mock_run, mock_which, tmp_path, monkeypatch
|
||||||
):
|
):
|
||||||
sessions_dir = tmp_path / "sessions"
|
sessions_dir = tmp_path / "sessions"
|
||||||
@@ -308,15 +344,16 @@ class TestStartSession:
|
|||||||
monkeypatch.setattr(
|
monkeypatch.setattr(
|
||||||
claude_session, "_SESSIONS_FILE", sessions_dir / "active.json"
|
claude_session, "_SESSIONS_FILE", sessions_dir / "active.json"
|
||||||
)
|
)
|
||||||
bad_response = {"session_id": "abc"} # missing "result"
|
# Stream with no result line at all
|
||||||
mock_run.return_value = _make_proc(stdout=json.dumps(bad_response))
|
bad_stream = json.dumps({"type": "assistant", "message": {"content": []}})
|
||||||
|
mock_run.return_value = _make_proc(stdout=bad_stream)
|
||||||
|
|
||||||
with pytest.raises(RuntimeError, match="missing required field"):
|
with pytest.raises(RuntimeError, match="no result line"):
|
||||||
start_session("general", "Hello")
|
start_session("general", "Hello")
|
||||||
|
|
||||||
@patch("shutil.which", return_value="/usr/bin/claude")
|
@patch("shutil.which", return_value="/usr/bin/claude")
|
||||||
@patch("subprocess.run")
|
@patch("subprocess.run")
|
||||||
def test_missing_session_id_field_raises(
|
def test_missing_session_id_gives_empty_string(
|
||||||
self, mock_run, mock_which, tmp_path, monkeypatch
|
self, mock_run, mock_which, tmp_path, monkeypatch
|
||||||
):
|
):
|
||||||
sessions_dir = tmp_path / "sessions"
|
sessions_dir = tmp_path / "sessions"
|
||||||
@@ -325,8 +362,10 @@ class TestStartSession:
|
|||||||
monkeypatch.setattr(
|
monkeypatch.setattr(
|
||||||
claude_session, "_SESSIONS_FILE", sessions_dir / "active.json"
|
claude_session, "_SESSIONS_FILE", sessions_dir / "active.json"
|
||||||
)
|
)
|
||||||
bad_response = {"result": "hello"} # missing "session_id"
|
# Result line without session_id → _run_claude returns "" for session_id
|
||||||
mock_run.return_value = _make_proc(stdout=json.dumps(bad_response))
|
# → start_session checks for empty session_id
|
||||||
|
bad_stream = _make_stream("hello", result_override={"session_id": None})
|
||||||
|
mock_run.return_value = _make_proc(stdout=bad_stream)
|
||||||
|
|
||||||
with pytest.raises(RuntimeError, match="missing required field"):
|
with pytest.raises(RuntimeError, match="missing required field"):
|
||||||
start_session("general", "Hello")
|
start_session("general", "Hello")
|
||||||
|
|||||||
Reference in New Issue
Block a user