Critical fix based on user analysis: PROBLEM: Cleanup is called in 2 contexts with different requirements: 1. BEFORE restore (from rman_restore): Should NOT shutdown 2. AFTER restore (from weekly-test): MUST shutdown to delete files USER INSIGHT: "Why shutdown if restore will clean anyway? But AFTER restore, you MUST shutdown to release file locks for deletion!" SOLUTION: Add /AFTER parameter to cleanup_database.ps1: WITHOUT /AFTER (before restore): - Skip SHUTDOWN ABORT - Skip Stop-Service - Leave service in current state (running/stopped) - Files CAN be deleted (no lock before restore) - Optimization: If service running → restore saves ~30s WITH /AFTER (after restore): - SHUTDOWN ABORT (stop instance) - Stop-Service (release file locks) - REQUIRED for file deletion after restore - Files are locked by active instance/service CALL SITES: 1. rman_restore: cleanup_database.ps1 /SILENT (no /AFTER) 2. weekly-test: cleanup_database.ps1 /SILENT /AFTER (with /AFTER) FLOW OPTIMIZATION: Test 1: Service stopped → start(30s) → restore → cleanup /AFTER Test 2: Service stopped → start(30s) → restore → cleanup /AFTER → No improvement yet BUT if we keep service running between tests: Test 1: Service stopped → start(30s) → restore → cleanup /AFTER Test 2: Service running → restore(0s saved!) → cleanup /AFTER → Save 30s on subsequent tests! Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
140 lines
5.9 KiB
PowerShell
140 lines
5.9 KiB
PowerShell
# Oracle Database Complete Cleanup Script (PowerShell)
|
|
# Purpose: Remove all database files and services to restore DR VM to clean state
|
|
# Run as: Administrator
|
|
# Location: D:\oracle\scripts\cleanup_database.ps1
|
|
#
|
|
# Parameters:
|
|
# /SILENT - Non-interactive mode
|
|
# /AFTER - Cleanup AFTER restore (shutdown instance + stop service before deleting files)
|
|
|
|
$ErrorActionPreference = "Continue"
|
|
|
|
$env:ORACLE_HOME = "C:\Users\Administrator\Downloads\WINDOWS.X64_193000_db_home"
|
|
$env:ORACLE_SID = "ROA"
|
|
$env:PATH = "$env:ORACLE_HOME\bin;$env:PATH"
|
|
|
|
Write-Host "============================================"
|
|
Write-Host "Oracle Database Cleanup Script"
|
|
Write-Host "============================================"
|
|
Write-Host ""
|
|
Write-Host "This script will:"
|
|
Write-Host " 1. Stop and delete Oracle service"
|
|
Write-Host " 2. Delete all database files (datafiles, control files, redo logs)"
|
|
Write-Host " 3. Delete local FRA (backups are on F:\, safe to delete)"
|
|
Write-Host " 4. Delete trace files"
|
|
Write-Host " 5. Leave VM in completely clean state (no service, no DB files)"
|
|
Write-Host ""
|
|
|
|
# Check parameters
|
|
$silent = $args -contains "/SILENT" -or $args -contains "/AUTO"
|
|
$afterRestore = $args -contains "/AFTER"
|
|
|
|
if (-not $silent) {
|
|
Write-Host "WARNING: This will DELETE the entire database!" -ForegroundColor Red
|
|
Write-Host "Starting cleanup in 3 seconds... (Press Ctrl+C to cancel)"
|
|
Start-Sleep -Seconds 3
|
|
}
|
|
|
|
# Create directories
|
|
New-Item -ItemType Directory -Path "D:\oracle\temp" -Force | Out-Null
|
|
New-Item -ItemType Directory -Path "D:\oracle\logs" -Force | Out-Null
|
|
|
|
Write-Host ""
|
|
if ($afterRestore) {
|
|
Write-Host "[1/6] Shutting down database (cleanup AFTER restore)..."
|
|
|
|
# Check if Oracle service exists
|
|
$service = Get-Service -Name "OracleServiceROA" -ErrorAction SilentlyContinue
|
|
if ($service) {
|
|
Write-Host " Oracle service found, attempting shutdown..."
|
|
|
|
# Shutdown instance using SQL*Plus
|
|
$shutdownSQL = "WHENEVER SQLERROR CONTINUE`nSHUTDOWN ABORT;`nEXIT;"
|
|
try {
|
|
$shutdownSQL | & sqlplus -S / as sysdba 2>&1 | Out-Null
|
|
Start-Sleep -Seconds 2
|
|
Write-Host " Instance shut down"
|
|
} catch {
|
|
Write-Host " Shutdown command sent (errors ignored)"
|
|
}
|
|
|
|
# Stop Oracle service to release file locks
|
|
if ($service.Status -eq "Running") {
|
|
Write-Host " Stopping Oracle service to release file locks..."
|
|
try {
|
|
Stop-Service -Name "OracleServiceROA" -Force -ErrorAction Stop
|
|
Start-Sleep -Seconds 2
|
|
Write-Host " Service stopped"
|
|
} catch {
|
|
Write-Host " WARNING: Failed to stop service: $_" -ForegroundColor Yellow
|
|
}
|
|
}
|
|
|
|
# Force kill any remaining Oracle processes
|
|
Get-Process -Name "sqlplus" -ErrorAction SilentlyContinue | Stop-Process -Force -ErrorAction SilentlyContinue
|
|
Get-Process -Name "oracle" -ErrorAction SilentlyContinue | Stop-Process -Force -ErrorAction SilentlyContinue
|
|
} else {
|
|
Write-Host " Oracle service not found, skipping shutdown"
|
|
}
|
|
Start-Sleep -Seconds 2
|
|
} else {
|
|
Write-Host "[1/6] Skipping instance shutdown (cleanup BEFORE restore)"
|
|
Write-Host " Instance and service left in current state"
|
|
Write-Host " Restore script will handle service state properly"
|
|
}
|
|
|
|
Write-Host "[2/6] Oracle service preserved for reuse"
|
|
if ($afterRestore) {
|
|
Write-Host " Service stopped to release file locks"
|
|
} else {
|
|
Write-Host " Service remains in current state (running or stopped)"
|
|
Write-Host " Optimization: If running, restore saves ~30s startup time"
|
|
}
|
|
|
|
Write-Host "[3/6] Deleting database files + SPFILE..."
|
|
Write-Host " Deleting datafiles..."
|
|
Remove-Item "C:\Users\oracle\oradata\ROA\*.dbf" -Force -ErrorAction SilentlyContinue
|
|
Write-Host " Deleting control files..."
|
|
Remove-Item "C:\Users\oracle\oradata\ROA\*.ctl" -Force -ErrorAction SilentlyContinue
|
|
Write-Host " Deleting redo logs..."
|
|
Remove-Item "C:\Users\oracle\oradata\ROA\*.log" -Force -ErrorAction SilentlyContinue
|
|
Write-Host " Deleting SPFILE (ensures PFILE-based startup)..."
|
|
Remove-Item "$env:ORACLE_HOME\database\SPFILE*.ORA" -Force -ErrorAction SilentlyContinue
|
|
|
|
Write-Host "[4/6] Deleting local FRA (backups are on F:\)..."
|
|
if (Test-Path "C:\Users\oracle\recovery_area\ROA") {
|
|
Remove-Item "C:\Users\oracle\recovery_area\ROA" -Recurse -Force -ErrorAction SilentlyContinue
|
|
New-Item -ItemType Directory -Path "C:\Users\oracle\recovery_area\ROA" -Force | Out-Null
|
|
Write-Host " FRA cleared"
|
|
} else {
|
|
New-Item -ItemType Directory -Path "C:\Users\oracle\recovery_area\ROA" -Force | Out-Null
|
|
Write-Host " FRA directory created"
|
|
}
|
|
|
|
Write-Host "[5/6] Deleting trace files (to save space)..."
|
|
Remove-Item "C:\Users\oracle\diag\rdbms\roa\ROA\trace\*.trc" -Force -ErrorAction SilentlyContinue
|
|
Remove-Item "C:\Users\oracle\diag\rdbms\roa\ROA\trace\*.trm" -Force -ErrorAction SilentlyContinue
|
|
Write-Host " Trace files deleted"
|
|
|
|
Write-Host ""
|
|
Write-Host "============================================"
|
|
Write-Host "Database Cleanup Complete!"
|
|
Write-Host "============================================"
|
|
Write-Host ""
|
|
Write-Host "Current state:"
|
|
Write-Host " [YES] Oracle software installed"
|
|
Write-Host " [YES] PFILE exists (C:\Users\oracle\admin\ROA\pfile\initROA.ora)"
|
|
Write-Host " [YES] Oracle service (preserved, will be reused)"
|
|
Write-Host " [NO] SPFILE (deleted to ensure PFILE startup)"
|
|
Write-Host " [NO] Database files (will be restored from backups)"
|
|
Write-Host " [NO] Control files (will be restored from backups)"
|
|
Write-Host " [NO] Datafiles (will be restored from backups)"
|
|
Write-Host ""
|
|
Write-Host "VM is now in CLEAN STATE (service preserved)!"
|
|
Write-Host ""
|
|
Write-Host "Next step: Run D:\oracle\scripts\rman_restore_from_zero.ps1"
|
|
Write-Host " (It will reuse the existing Oracle service and restore the database)"
|
|
Write-Host ""
|
|
|
|
exit 0
|